TIMOB-8825: BlackBerry: Implement UI.OptionDialog #54
Conversation
Reviewers: DavidC, HarutM ChangeLog: - Implemented native DropDown, Option classes - Implemented selectedIndex, options, title property and methods - Updated yaml doc for OptionsDialog Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance optiondialog object on some event. - Show optionDialog. - Make sure mentioned methods work.
| for (unsigned int i = 0; i < uiLength; ++i) | ||
| { | ||
| Handle<Value> l = array->Get(Integer::New(i)); | ||
| String::Utf8Value v8UtfString(Handle<String>::Cast(l)); |
There was a problem hiding this comment.
You should check that each array entry can be cast to a string successfully, e.g. if (l->IsString()) etc...
|
reviewed |
| @@ -128,7 +134,7 @@ properties: | |||
|
|
|||
| - name: selectedIndex | |||
| summary: Defines the default selected option. | |||
| platforms: [android] | |||
| platforms: [android, blackberry] | |||
| type: Number | |||
| availability: creation | |||
|
|
|||
There was a problem hiding this comment.
Since you're the first to update yml files, also update the docgent.py to contain the DEFAULT_BLACKBERRY_SINCE = "2.1" and add blackberry to the DEFAULT_PLATFORMS.
You'll also need to make use of DEFAULT_BLACKBERRY_SINCE in a similar fashion to DEFAULT_MOBILEWEB_SINCE
Reviewers: DavidC, HarutM ChangeLog: - Modify docgen.py script for blackberry platform needs. - Updated yaml doc for OptionsDialog upon comments. - Minor changes upon comments. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance optiondialog object on some event. - Show optionDialog. - Make sure mentioned methods work. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform
|
validate.py in apidoc reports the following: Probably just need to add blackberry in the proper list inside the script |
|
|
||
| On BlackBerry the control consists of a title bar and an expandable list of options. | ||
| The purpose is to give the app developer a simple way to let the user select one of many options. | ||
| The list expands/collapses when tapping on the title bar, and collapses when tapping on an option in the list. |
There was a problem hiding this comment.
Looking at the other descriptions, this should cover where the option dialog is displayed on the screen, for iOS and Android it's in the middle or against an edge. It's appropriate to describe the same sort of info for the BB. If it can be displayed anywhere in the screen, then just say so.
Reviewers: DavidC, HarutM ChangeLog: - Minor fixes - Updated yaml doc for OptionsDialog. Added ipad platform Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance optiondialog object on some event. - Show optionDialog. - Make sure mentioned methods work.
|
Updated. |
Reviewers: DavidC, HarutM ChangeLog: - Add blackerry platform in supported platforms in validate.py script - Updated yaml doc for OptionsDialog. Added ipad platform Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance optiondialog object on some event. - Show optionDialog. - Make sure mentioned methods work.
|
Fixed missed comments |
|
approved |
|
Nothing to add for me Alex, it seems pretty clear that this control will need to use a modal dialog in the future, I expect dialogs to be available in R6. Thanks |
…berry' into dropdownBranch Conflicts: blackberry/tibb/NativeControlObject.cpp blackberry/tibb/NativeControlObject.h blackberry/tibb/TiUIBase.cpp
|
Code merged with upstream. |
TIMOB-8825: BlackBerry: Implement UI.OptionDialog
Reviewers: DavidC, HarutM
ChangeLog:
Test Cases: