TIMOB-8815: BlackBerry: Implement UI.Button #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: JP, HarutM ChangeLog: - Implement image property and method. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance button object with image property. - Make sure image appear on button.
|
Add the yaml update |
|
Do add the URL to this PR in the jira issue, as a comment. |
|
Reviewed |
|
Approved |
Reviewers: JP, HarutM ChangeLog: - Added yaml update for UI.Button. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance button object with image property. - Make sure image appear on button.
|
Updated. |
|
Also add the platforms to all the methods that are not supported by the BB button. Basically the documentation should reflect the state of the Button implementation as if no more work was going to be done. So all non implemented methods/properties in BB need to list all other platforms supporting it |
Reviewers: JP, HarutM ChangeLog: - Add the platforms to all the methods that are not supported by the BB button UI.Button in yaml doc. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance button object with image property. - Make sure image appear on button. •- Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform
|
Pushed a new commit to resolve JP's comment. |
|
Approved |
1 similar comment
|
Approved |
alexandergalstyan
added a commit
that referenced
this pull request
May 22, 2012
TIMOB-8815: BlackBerry: Implement UI.Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: JP, HarutM
ChangeLog:
Test Cases: