TIMOB-9158 Blackberry: Update the tibbapp project to work with the R4 release of Cascades #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… release of Cascades
Changelog:
- Update lib dependencies in common.mk
- rename cascades_user_main to main
- add placeholders for icon and splashscreen in bar descriptor
- use default titanium assets for these
- Update bbndk path for default detection
- Copy bb assets at packaging time
- Remove icon.png file
NOTE: Created https://jira.appcelerator.org/browse/TIMOB-9164 to track updating of bar-descriptor at packaging time
Tests:
- Update ndk path in titanium studio (beta version supporting BB)
- build and install the sdk zip
- create new project, use app.js from tibbtest
- run on simulator
==> Verify it works and uses the titanium icon
NOTE: the splashscreen doesn't seem to work, i'm currently checking with Suavek to know if the support exists for it in R4
- Ran blackberryndk.py by itself to ensure it now defaults to the R4 version for autodetection
| os.makedirs(assetsDir) | ||
| if os.path.exists(assetsDir): | ||
| shutil.rmtree(assetsDir) | ||
| shutil.copytree(os.path.join(projectDir, 'Resources', 'blackberry'), assetsDir) | ||
| shutil.copy2(os.path.join(projectDir, 'Resources', 'app.js'), assetsDir) | ||
|
|
||
| if platform.system() == 'Windows': |
There was a problem hiding this comment.
The command after:
command = [packager, '-package', package, 'bar-descriptor.xml', '-e', savePath, projectName, 'icon.png', 'assets']
has icon.png which not exist anymore.
There was a problem hiding this comment.
removed icon.png from the command
|
The rest seems ok. Reviewed |
Renamed savePath to appFile Updated comment about copying assets Tested that the packaging step still works well from Studio
|
Pushed a new commit to resolve Alex's comment |
|
Approved |
1 similar comment
|
Approved |
jpl-mac
pushed a commit
that referenced
this pull request
May 22, 2012
TIMOB-9158 Blackberry: Update the tibbapp project to work with the R4 release of Cascades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, DL
Changelog:
NOTE: Created https://jira.appcelerator.org/browse/TIMOB-9164 to track updating of bar-descriptor at packaging time
Tests:
==> Verify it works and uses the titanium icon
NOTE: the splashscreen doesn't seem to work, i'm currently checking with Suavek to know if the support exists for it in R4