TIMOB-8835: BlackBerry: Implement UI.Switch #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: JP, DavidL ChangeLog: - Implemented native ToggleButton class - Implemented checked property, methods - Updated yaml doc for ToggleButton Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance switch object. - Make sure existing property checked (value) works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform NOTE: in validate.py script's supported platforms sections blackberry platform added as a part of another PR
| @@ -11,6 +11,8 @@ description: | | |||
| On Mobile Web, a switch always has text associated with it, and appears as a | |||
| toggle button, similar to Android. | |||
|
|
|||
| On BlackBerry, a switch is a fixed-size switch control with two states: checked or unchecked. | |||
There was a problem hiding this comment.
This description should be more along the lines of what is done for the other platform. Specifically for the switch, the main difference among platforms seems to be the support for associated text with the switch.
So the description needs to cover that, does the BB toggle button support associated text like android and mobileweb or does it not, like iOS?
|
Reviewed |
…rry' into switchBranch #Some more info....
|
Updated. |
Reviewers: JP, DavidL ChangeLog: - Updated yaml doc for ToggleButton. - static functions names in TiUIObject changed to prefix underline. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance switch object. - Make sure existing property checked (value) works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform NOTE: in validate.py script's supported platforms sections blackberry platform added as a part of another PR
|
Thanks Alex, Approved |
|
Approved |
…rry' into switchBranch Conflicts: blackberry/tibb/NativeContainerObject.cpp blackberry/tibb/NativeObject.h blackberry/tibb/NativeObjectFactory.cpp blackberry/tibb/TiUIObject.cpp blackberry/tibb/TiUIObject.h
|
Merged with upstream |
alexandergalstyan
added a commit
that referenced
this pull request
May 24, 2012
TIMOB-8835: BlackBerry: Implement UI.Switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: JP, DavidL
ChangeLog:
Test Cases:
NOTE: in validate.py script's supported platforms sections blackberry platform added as a part of another PR