TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts (partial) TIMOB-8944: BlackBerry: Connect drillbit to BB simulator or device [Added] devicemanagement.py [Changes] blackberry.js - function BlackBerrySimulator - added member blackberryDeviceManagement - added function createDeviceManagementProcess - removed unused function getTestHarnessPID, testHarnessNeedsBuild - implemented functions isTestHarnessRunning, fillTestTemplateData, pushTestJS, stageSDK, killTestHarness - function run - create a placeholder process for logs and uncomment the code that uses it - functions launchTestHarness, runTestHarness - removed unused variable blackberryndk.py - function package - added parameter type and use it to package using devMode builder.py - remember and pass along the type [Tests] Test 1: Run drillbit 1) Run scons to build the mobile sdk 2) Run the following command: drillbit\drillbit.py --platforms=blackberry 3) Click "run tests" 4) Verify the test_harness app is built, deployed, and run 5) Close drillbit and repeat Step 2 6) Verify the test_harness app is closed when drillbit starts
| with open(os.devnull, 'w') as nul: | ||
| sys.stdout = nul | ||
| tiappxml = TiAppXML(project_tiappxml, True) | ||
| sys.stdout = sys.__stdout__ |
There was a problem hiding this comment.
To be clean this should save and restore the initial value of sys.stdout and not blindly set it to stdout
- centralized program names - make echoing the command optional (default is true) - if there is a log but no file, output to stdout instead of nowhere - moved command building from devicemanagement.py to blackberryndk.py - fixed blackberryndk.py unit tests - made Builder.type2variantCpu public - remember stdout and use it
|
Updated patch. I'll ask David C to re-review. |
|
Thanks David |
|
Approved. Tests are passed. |
dlifshitz-maca
added a commit
that referenced
this pull request
May 30, 2012
TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers:David C, Harut
[Issues Fixed]
TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts
(partial) TIMOB-8944: BlackBerry: Connect drillbit to BB simulator or device
[Added]
devicemanagement.py
[Changes]
blackberry.js
blackberryndk.py
builder.py
[Tests]
Test 1: Run drillbit
drillbit\drillbit.py --platforms=blackberry