TIMOB-8996: Complete remaining issues from code review #60
Conversation
|
The one problem found is setLeft, setRight, setTop, setBottom don't work with current solution. |
| @@ -15,6 +15,9 @@ | |||
| { | |||
| isInitialized_ = false; | |||
| parentObject_ = NULL; | |||
| #ifdef _TI_DEBUG_ | |||
| cstrName_ = NULL; | |||
| #endif // _TI_DEBUG_ | |||
There was a problem hiding this comment.
Probably it will correct to initialize other debug members here.
|
This PR, needs to be merged with upstream. |
|
David, do add the url to this PR in the jira issue comments |
| { | ||
| return error; | ||
| } | ||
| ((bb::cascades::Control*)getNativeHandle())->setBottomMargin(bottom); |
There was a problem hiding this comment.
setBottom should set bottom property which is View's bottom position in container, but bottomMargin margins specifies the space around a control.
e.g. for absolute layout it doesn't work.
There was a problem hiding this comment.
These should likely also take into account the layout rules as set out by appcel. These props (top, bottom, left, right) have relative priority and depending on the cases, some may need to be ignored.
There was a problem hiding this comment.
These will change in future patches. All view objects will be embedded within a Cascades container.
|
reviewed |
| @@ -210,16 +225,14 @@ void TiUIBase::setParametersFromObject(Local<Object> obj) | |||
| Handle<Array> propNames = obj->GetPropertyNames(); | |||
| uint32_t props = propNames->Length(); | |||
| Local<Value> propValue; | |||
|
Looks like
Are the only issues not addressed in this patch, David can you create another issue for 7 and link it to 8996. |
|
The issues not addressed have been moved into separate tasks: |
|
Thanks Dave, please also add the url of this PR to the JIRA issue |
|
Approved |
|
Alex, have you approved this patch? |
|
Rather than this: "Please use prefix _ for static member functions, instead of suffix" (TiUIObject.*), I have nothing to add. Though that could be done separately. |
Conflicts: blackberry/tibb/NativeControlObject.cpp blackberry/tibb/TiUIBase.cpp blackberry/tibb/TiUIObject.h
TIMOB-8996: Complete remaining issues from code review
Reviewers: Alex, Harut
Description:
Clean up code from previous code reviews
Change Log:
Test Cases: