TIMOB-8821: BlackBerry: Implement UI.Label #61

alexandergalstyan · 2012-05-23T16:10:57Z

Reviewers: JP, HarutM

ChangeLog:

Added new NativeAbstractTextControlObject as a parent for Label, TextField, TextArea controls.
Implemented font, textAlign, color properties, methods
Move appropriate methods from Label control into the parent
Updated yaml doc for Label

Test Cases:

Build tibb.
Build tibbtest.
In the java script, instance label object with font, textAlign, color properties.
Make sure existing mentioned properties works.
Run docgen.py script
Make sure documentation includes appropriates changes for blackberry platform

Reviewers: JP, HarutM ChangeLog: - Added new NativeAbstractTextControlObject as a parent for Label, TextField, TextArea controls. - Implemented font, textAlign, color properties, methods - Move appropriate methods from Label control into the parent - Updated yaml doc for Label Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

jpl-mac · 2012-05-25T13:16:17Z

blackberry/tibb/NativeAbstractTextControlObject.cpp

+#include <bb/cascades/controls/abstracttextcontrol.h>
+#include <bb/cascades/controls/textalignment.h>
+#include <qt4/QtCore/qmap.h>
+#include <qt4/QtCore/qstring.h>


You only need to include the class name for Qt classes, like so:

#include <QMap> #include <QString>

I don't think there's an equivalent for cascades classes though

Harutyun · 2012-05-25T14:49:27Z

Reviewed

jpl-mac · 2012-05-25T15:01:06Z

blackberry/tibb/NativeAbstractTextControlObject.h

+
+private:
+    bb::cascades::AbstractTextControl* textControl_;
+};


Also disable the copy ctor and assignment operator

jpl-mac · 2012-05-25T16:37:22Z

Reviewed

…ry' into labelBranch #Some more info....

Reviewers: JP, HarutM ChangeLog: - Minor fixes - Update NativeTextFieldObject to be derived from NativeAbstractTextControlObject - Move string constants to defines - Add width, height properties to native control object Test Cases: -Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

alexandergalstyan · 2012-05-29T10:57:05Z

Updated

jpl-mac · 2012-05-29T21:33:40Z

blackberry/tibb/TiUIBase.cpp

+
+    {
+        "height", TI_PROP_PERMISSION_READ | TI_PROP_PERMISSION_WRITE,
+        N_PROP_HEIGHT
    }


These should be in order, can you please order the ones that were added to the end?

jpl-mac · 2012-05-29T21:39:15Z

Reviewed

Reviewers: JP, HarutM ChangeLog: - Address comments Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

alexandergalstyan · 2012-05-30T09:35:52Z

updated

jpl-mac · 2012-05-30T14:22:55Z

blackberry/tibb/NativeAbstractTextControlObject.cpp

+        textControl_->textStyle()->setAlignment(bb::cascades::TextAlignment::ForceRight);
+        break;
+    default:
+        qDebug() << "Unknown value recieved: " << value;


s/recieved/received/

Also log the class name and method name, so the origin of the log can be found easily. Goes for all logging messages

jpl-mac · 2012-06-01T12:58:18Z

For #61 (comment) , the constants defined as javascript constants.
Please show me where that is done as I must have missed it, I don't see where that is done.

For #61 (comment) , still waiting for Suavek response, since cannot find appropriate docs for that

The Font doc still needs to be updated to reflect the work of this PR. Not all of it needs answers from Suavek. You can add notes to Jira for things that will need to be updated once we get answers from Suavek. You can still update the Font.yml file for this PR with the information that you have, unless you prefer to delay this patch until you get the answers.

fontFamily: Do you know which fonts are supported currently? (Question sent to Suavek) Does that mean that setting fontFamily currently doesn't work? If so this must be captured in Jira to be updated at a later time when we get answers

The rest of the properties you can update now

fontSize: what unit does the BB use? should the unit be appended to the number?
fontStyle: does italic work? currently it says only supported for iphone ipad
fontWeight: do bold and semibold work?
If you've tested your work you should already know most of these answers

If there are still things that need to be updated but need to wait for R6 to find the answers then add them to the JIra Issue for reworking label/font after R6

jpl-mac · 2012-06-01T13:02:11Z

What is ver5? I don't think you understand defining read-only constants in the javascript API.

The user needs to be able to do something like

var v = Ti.UI.TEXT_ALIGNMENT_CENTER;

I don't see that from the code.

jpl-mac · 2012-06-01T14:14:37Z

Concerning the read-only vars, you can talk to DavidC about how to go about adding the constants in V8. Once that's done, you have to update the Ti.UI yml file. It contains the following line for the TEXT_ALIGNMENT_* properties:

This constant is a string on android, and a number on iOS and mobileweb.

It needs to be updated to specify the type for the constant on BB. I expect that it will be a number.

Reviewers: JP, HarutM ChangeLog: - Updated Font.yml - Updated UI.yml - Added text alignment javascript constants Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

alexandergalstyan · 2012-06-01T16:39:39Z

Updated

jpl-mac · 2012-06-01T18:13:19Z

apidoc/Titanium/UI/Font.yml

@@ -61,6 +61,9 @@ description: |

    * [Custom Fonts in the Titanium Mobile Guides](https://wiki.appcelerator.org/display/guides/Custom+Fonts)

+    * On BlackBerry, fontSize use post script units. Valid ranges are >= 0. Sizes < 0 will be clamped to 0.
+      fontWeight valid values are "bold" or "normal."


Thanks Alex,

This should be in the fontSize specific description. As for the fontWeight, it matches what's already in the description.

Reviewers: JP, HarutM ChangeLog: - Updated yaml doc for Font, UI - Minor fixes Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

alexandergalstyan · 2012-06-05T14:09:08Z

Updated

jpl-mac · 2012-06-05T15:26:07Z

apidoc/Titanium/UI/Font.yml

@@ -92,6 +91,8 @@ properties:
        For example, "16dp" specifies a size of 16 density-independent pixels. 

        iOS ingores any unit specifier after the size value.
+
+        On BlackBerry, fontSize use post script units. Valid ranges are >= 0. Sizes < 0 will be clamped to 0.


Should also specify that we value should be a Number. String currently also work but only if not followed by unit specifier (either we have it ignore the unit specifiers like for iOS or update the doc to specify that it only takes a number).

Reviewers: JP, HarutM ChangeLog: - Update Font.yml Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

jpl-mac · 2012-06-05T18:30:15Z

blackberry/tibb/TiObject.h

+    TEXT_ALIGNMENT_CENTER,
+    TEXT_ALIGNMENT_RIGHT
+};
+


Moving this causes a compile error because NativeAbstractTextControlObject.cpp still references these.

After discussing this with David C, we came to the conclusion that we should have a new file named TiConstants.h to contain all the constants definitions that will be needed throughout the TI api. This file will then be included in both places. The Constants should also be declared in a Ti namespace to avoid name clashes.

There is a macro that we'll use to not have to write the .cpp manually.

…ry' into labelBranch Conflicts: blackberry/tibb/NativeControlObject.cpp blackberry/tibb/NativeControlObject.h blackberry/tibb/NativeTextFieldObject.cpp blackberry/tibb/NativeTextFieldObject.h blackberry/tibb/TiUIBase.cpp

Reviewers: JP, HarutM ChangeLog: - Added TiConstants.h file to containt all Ti constants. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

alexandergalstyan · 2012-06-06T09:29:47Z

Merged with latest and updated.

jpl-mac · 2012-06-06T13:42:51Z

apidoc/Titanium/UI/Font.yml

+
+        On BlackBerry, fontSize use post script units. Valid ranges are >= 0. Sizes < 0 will be clamped to 0.
+        fontSize value should be a Number. String currently also work but only if not followed by unit specifier.
+        BlackBerry ingores any unit specifier after the size value.


Change fontSize value should be a Number. to fontSize value is a Number.
Remove String currently also work but only if not followed by unit specifier. that was just a note i was telling you
Remove BlackBerry ingores any unit specifier after the size value. as it is not true, currently if the fontSize is a string with a unit specifier the conversion fails, it does not ignore the unit specifier

alexandergalstyan · 2012-06-06T13:54:31Z

Updated

Reviewers: JP, HarutM ChangeLog: - Update apidoc for Font and TextField. Test Cases: - Build tibb. - Build tibbtest. - In the java script, instance label object with font, textAlign, color properties. - Make sure existing mentioned properties works. - Run docgen.py script - Make sure documentation includes appropriates changes for blackberry platform

jpl-mac · 2012-06-06T14:31:46Z

Approved

TIMOB-8821: BlackBerry: Implement UI.Label

…ry' into labelBranch #Some more info....

TIMOB-8821: BlackBerry: Implement UI.Label

jpl-mac reviewed May 25, 2012
View reviewed changes

unknown added 2 commits May 29, 2012 12:36

Merge branch 'labelBranch', remote-tracking branch 'upstream/blackber…

18b31bb

…ry' into labelBranch #Some more info....

jpl-mac reviewed May 29, 2012
View reviewed changes

jpl-mac reviewed May 30, 2012
View reviewed changes

jpl-mac closed this Jun 1, 2012

jpl-mac reopened this Jun 1, 2012

jpl-mac reviewed Jun 1, 2012
View reviewed changes

jpl-mac reviewed Jun 5, 2012
View reviewed changes

unknown added 2 commits June 6, 2012 13:10

jpl-mac reviewed Jun 6, 2012
View reviewed changes

Merge pull request Macadamian#61 from alexandergalstyan/labelBranch

27868f2

TIMOB-8821: BlackBerry: Implement UI.Label

alexandergalstyan closed this Jun 6, 2012

alexandergalstyan reopened this Jun 6, 2012

Merge branch 'labelBranch', remote-tracking branch 'upstream/blackber…

a9cd856

…ry' into labelBranch #Some more info....

alexandergalstyan added a commit that referenced this pull request Jun 6, 2012

Merge pull request #61 from alexandergalstyan/labelBranch

5156a9d

TIMOB-8821: BlackBerry: Implement UI.Label

alexandergalstyan merged commit 5156a9d into Macadamian:blackberry Jun 6, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TIMOB-8821: BlackBerry: Implement UI.Label #61

TIMOB-8821: BlackBerry: Implement UI.Label #61

alexandergalstyan commented May 23, 2012

jpl-mac May 25, 2012

alexandergalstyan May 29, 2012

Harutyun commented May 25, 2012

jpl-mac May 25, 2012

alexandergalstyan May 29, 2012

jpl-mac commented May 25, 2012

alexandergalstyan commented May 29, 2012

jpl-mac May 29, 2012

alexandergalstyan May 30, 2012

jpl-mac commented May 29, 2012

alexandergalstyan commented May 30, 2012

jpl-mac May 30, 2012

jpl-mac commented Jun 1, 2012

jpl-mac commented Jun 1, 2012

jpl-mac commented Jun 1, 2012

alexandergalstyan commented Jun 1, 2012

jpl-mac Jun 1, 2012

alexandergalstyan Jun 5, 2012

alexandergalstyan commented Jun 5, 2012

jpl-mac Jun 5, 2012

alexandergalstyan Jun 5, 2012

jpl-mac Jun 5, 2012

alexandergalstyan commented Jun 6, 2012

jpl-mac Jun 6, 2012

alexandergalstyan commented Jun 6, 2012

jpl-mac commented Jun 6, 2012

TIMOB-8821: BlackBerry: Implement UI.Label #61

TIMOB-8821: BlackBerry: Implement UI.Label #61

Conversation

alexandergalstyan commented May 23, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Harutyun commented May 25, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpl-mac commented May 25, 2012

alexandergalstyan commented May 29, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpl-mac commented May 29, 2012

alexandergalstyan commented May 30, 2012

Choose a reason for hiding this comment

jpl-mac commented Jun 1, 2012

jpl-mac commented Jun 1, 2012

jpl-mac commented Jun 1, 2012

alexandergalstyan commented Jun 1, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexandergalstyan commented Jun 5, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexandergalstyan commented Jun 6, 2012

Choose a reason for hiding this comment

alexandergalstyan commented Jun 6, 2012

jpl-mac commented Jun 6, 2012