TIMOB-8838: <BlackBerry: Implement UI.TableView> #62
Conversation
Reviewers: Alex, Davic C. Change Log: - implemented BB support of tableView controller - implemented dictionary JV type parser - fixed issues which came from some merge for textField TestCases - build tibb - build tibtest - instance java script tableView object with certain properties implemented here - make run tibbtest project make sure properties/events are working - run docgen.py script - make sure documentation includes updates
|
Please add the URL to this PR in the jira issue comments. |
|
Done: |
| @@ -190,7 +190,7 @@ methods: | |||
| events: | |||
| - name: click | |||
| summary: Fired when a table row is clicked by the user. | |||
| platforms: [android, iphone, ipad, mobileweb] | |||
| platforms: [android, iphone, ipad, mobileweb, backberry] | |||
| properties: | |||
There was a problem hiding this comment.
should be blackberry, instead of 'backberry'.
Also say for method appendRow, since we don't implement it mark platforms as [android, iphone, ipad, mobileweb], and so on for others.
|
reviewed |
|
Approved |
|
You need to merge code. |
| @@ -337,3 +362,42 @@ int NativeControlObject::getStringArray(TiObject* obj, QVector<QString>& value) | |||
| } | |||
| return NATIVE_ERROR_OK; | |||
| } | |||
|
|
|||
| int NativeControlObject::getDictionaryData(TiObject* obj, multimap<QString, QString>& dictionary) | |||
There was a problem hiding this comment.
changed to QVector, because it needs to keep the order of elements
|
When is TableViewRow going to be implemented? Is there a jira task for it? |
| events: | ||
| - name: click | ||
| summary: Fired when a table row is clicked by the user. | ||
| platforms: [android, iphone, ipad, mobileweb] | ||
| platforms: [android, iphone, ipad, mobileweb, blackberry] |
There was a problem hiding this comment.
Are all the click event properties currently supported? If not the yml needs updating
|
What about TableViewIndexEntry? |
|
This jira task was created for TableViewRow https://jira.appcelerator.org/browse/TIMOB-8839 |
|
for TableViewIndexEntry created jira task and assigned to me: https://jira.appcelerator.org/browse/TIMOB-9290 |
| HandleScope handleScope; | ||
| TiUITableView* obj = (TiUITableView*) userContext; | ||
| NativeObject* no = obj->getNativeObject(); | ||
| Local<Integer> index = args[0]->ToInteger(); |
There was a problem hiding this comment.
Should verify that arg[0] is indeed an int before converting to integer. If it is not ToInteger will always return 0. This should at least be logged.
Just add a qDebug() <<
with the class name::function and something like "received arg is not an integer"
|
Thanks Harut, please change the toStd for toUtf8 at merge time |
Conflicts: blackberry/tibb/NativeContainerObject.cpp blackberry/tibb/NativeObjectFactory.cpp blackberry/tibb/TiCascadesEventHandler.cpp blackberry/tibb/TiCascadesEventHandler.h blackberry/tibb/TiUIObject.cpp blackberry/tibb/TiUIObject.h blackberry/tibb/moc_TiCascadesEventHandler.cpp
TIMOB-8838: <BlackBerry: Implement UI.TableView>
Reviewers: Alex, Davic C.
Change Log:
TestCases
implemented here