New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-8944: BlackBerry: BlackBerry: Connect drillbit to BB simulator or device #64
TIMOB-8944: BlackBerry: BlackBerry: Connect drillbit to BB simulator or device #64
Conversation
…or device [Issues Fixed] TIMOB-8944: BlackBerry: BlackBerry: Connect drillbit to BB simulator or device [Changes] blackberry.js - function run - removed useless blackberrySimulatorProcess - remember readLineCb - function launchTestHarness - when finished starting up the test harness, capture the logs and check the exit code - added stub function handleCompleteBlackBerryEvent blackberryndk.py - added functions printExitCode, _isAppRunning, _printAppLog, appLog devicemanagement.py - added commands and functions printExitCode, appLog [Tests] Test 1: Run drillbit 1) Run scons to build the mobile sdk 2) Run the following command: drillbit\drillbit.py --platforms=blackberry 3) Click "run tests" 4) Verify the test_harness app is built, deployed, and run 5) Close the app on the simulator 6) Verify the logs are printed Note: The test will not finish because the app was closed manually (not what should happen) and the framework doesn't yet output the Ti logging. If you want to see the test fail when the app crashes, put a return -1; in tibbapp/main.cpp.
Got following error while run tests: |
Tries to install pyxml, but that doesn't help |
That is very odd, but I don't see how my patch could have caused it. Can you try without this patch and check if the problem still exists? |
The same on clean branch for me. |
process.setOnReadLine(function(data) { | ||
var lines = data.split("\n"); | ||
lines.forEach(function(line) { | ||
if (line.indexOf("result::") === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Javascript, the == operator is a loose comparison so "0" == 0 is true. The === operator forces a stricter comparison so "0" === 0 is false. It's the same with !== below. Appcelerator's convention is to use === and !== when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, ignore then
approved |
TIMOB-8944: BlackBerry: BlackBerry: Connect drillbit to BB simulator or device
Reviewers: Alex, David C
Note: only review from 6f2d4fa
[Issues Fixed]
TIMOB-8944: BlackBerry: BlackBerry: Connect drillbit to BB simulator or device
[Changes]
blackberry.js
blackberryndk.py
devicemanagement.py
[Tests]
Test 1: Run drillbit
drillbit\drillbit.py --platforms=blackberry
Note: The test will not finish because the app was closed manually (not what should happen) and the framework doesn't yet output the Ti logging.
If you want to see the test fail when the app crashes, put a return -1; in tibbapp/main.cpp.