TIMOB-8990: Ti functions don't work in event callbacks #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: David L, Alex Description: This patch fixes the problem of JS functions not calling back to the runtime. This patch calls "setVisible(false)" in the "clicked" event on the button object. In previous verions, this wouldn't work because it was never passed to the runtime. Change Log: - created a callback for Cascades message loop - changed V8 scope so context doesn't go out of scope before events are handled - application exits when a JS exception occurs Test Cases: - build tibb - build tibbtest - run tibbtest in simulator or device - push the button - it should disappear Note: This patch addresses issues: https://jira.appcelerator.org/browse/TIMOB-8990 https://jira.appcelerator.org/browse/TIMOB-9203
|
Approved |
| } | ||
| // TODO: implement a message pump here | ||
| return bb::cascades::Application::exec(); | ||
| objectFactory_ = &objFactory; |
There was a problem hiding this comment.
I don't like the idea of setting a member variable with a reference to memory on the stack, but since it's a private member and seems to never get referenced after the function ends, it should be ok. If I'm wrong about referencing it later then this needs to be in the heap.
|
Approved. |
| objectFactory_ = &objFactory; | ||
| mainApp_ = &mainApp; | ||
| int ret = obj->executeScript(&objFactory, javaScript_, messageLoop, this); | ||
| // TODO: handle non-zero return code here |
There was a problem hiding this comment.
Is there a Jira associated with that TODO? Otherwise what's preventing this from being done as part of this patch? If there's a reason to do it separately, then let's make sure there is a jira tracking that
dcampbell-macadamian
added a commit
that referenced
this pull request
Jun 1, 2012
TIMOB-8990: Ti functions don't work in event callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: David L, Alex
Description:
This patch fixes the problem of JS functions not calling back to the runtime. This patch calls "setVisible(false)" in the "clicked" event on the button object. In previous verions, this wouldn't work because it was never passed to the runtime.
Change Log:
Test Cases:
Note:
This patch addresses issues:
https://jira.appcelerator.org/browse/TIMOB-8990
https://jira.appcelerator.org/browse/TIMOB-9203