TIMOB-8923: Blackberry: Scripts TODO Mac cleanup (part 1)

[dlifshitz-maca]

Reviewers: Alex, JP
Note: only review from c499affa

[Issues Fixed]
TIMOB-8923: Blackberry: Scripts TODO Mac cleanup (part 1)

[Changes]
android/builder.py

• don't pack blackberry stuff for android

blackberryndk.py

• removed old TODOs
• function package
  • copy the non-other-platform files in Resources and overwrite with files from the blackberry folder
• function __runUnitTests
  • use ip address, if given
  • run the package and deploy unit tests
• function main
  • add --ip_address for unit tests

blackberry/builder.py

• removed old TODOs

[Tests]
Test 1: Run unit tests

1. Run the following command:
   blackberryndk.py -t
2. Verify all 7 tests pass
3. Run the following command:
   blackberryndk.py -t --ip_address
4. Verify all 8 tests pass

[jpl-mac]

deploy test fails for me

Command '['blackberry-deploy', '-installApp', '-launchApp', '-device', '192.169.135.131', '-package', '/var/folders/dg/2crkq1ts6r31t90s7wky95g80000gp/T/tmpv14K6j/HelloWorldDisplayMakefile/x86/o-g/HelloWorldDisplayMakefile.bar']' returned non-zero exit status 1 None
Test deploy project to simulator.. FAILED

[dlifshitz-maca]

Can you enable the logs and post what went wrong?

[jpl-mac]

Command '['blackberry-deploy', '-installApp', '-launchApp', '-device', '192.169.135.131', '-package', '/var/folders/dg/2crkq1ts6r31t90s7wky95g80000gp/T/tmpfUqpfQ/HelloWorldDisplayMakefile/x86/o-g/HelloWorldDisplayMakefile.bar']' returned non-zero exit status 1 None
Test deploy project to simulator.. FAILED
    Traceback (most recent call last):
      File "support/blackberry/blackberryndk.py", line 332, in __runUnitTests
    assert 0 == ndk.deploy(ipAddress, barPath)
    AssertionError

Not that it will help much, let me know what more i can enable for debug

[dlifshitz-maca]

To enable the build log:
blackberryNdk.py, funcrtion _run, change

logfile = os.devnull

to

logfile = None

[jpl-mac]

Works now, i had a typo in the ip address :S Shame on me

[jpl-mac]

This change looks good, my interogation is wether this is consistant with what it done for other platforms. Should blackberry be dumped in the top assets dir or should it be kept as blackberry subfolder? By the same token, should the top directory event be named assets? maybe the name should be the same as for other platforms, otherwise it would need to be documented somewhere.

I think the resources treatment should be the same a on other platforms, so everything feels familiar to the Studio user.

[dlifshitz-maca]

The Ti docs say that Resources/ will be put wherever the stuff in Resources goes and that the other platform folders will be ignored. As for the the name and location of the assets dir I think it depends on the platform. I would have preferred to use "Resources" instead of "assets" but I don't see any benefits that outweigh the extra work.
For documentation for the Studio user I don't see a point since they won't care what's in the bar file. It's our code that needs to know.
http://docs.appcelerator.com/titanium/2.0/index.html#!/guide/Supporting_Multiple_Platforms_in_a_Single_Codebase section "Platform-specific resources"

[jpl-mac]

Thanks David for the information.

So long as the user doesn't need to reference assets in the path to resources then that's all good. In fact judging from the doc you referenced the user should never need to reference the resources folder. We may need to implement that but that is likely outside the scope of this patch.

[jpl-mac]

Reviewed

[alexandergalstyan]

Rather than already posted comments, seems ok. Need to merged with latest version of scripts containing ip_address, password.
Reviewed.

[dlifshitz-maca]

Updated

[jpl-mac]

Approved

[alexandergalstyan]

Approved