TIMOB-9309: BlackBerry: Convert argparse to optparse #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: DavidL, JP ChangeLog: - Convert argparse to optparse for builder.py script Test Cases: - Create sample project. - Run builder.py script with 'build' command - Make sure project successfully built. - Run builder.py script with 'run' command - Make sure project successfully ran. - Make sure script gives usage string in cases of missed or invalid arguments - Make sure script launches application when device password set in command line and simulator. - Make sure script launches application when device password set in command line and not set in simulator. - Make sure script fails to launch application when device password not set in command line and set in simulator. - Make sure script fails to launch application when invalid or incorrect ip address provided.
| @@ -111,8 +118,8 @@ def error(msg): | |||
| builder = Builder(args.project_path.decode('utf-8'), args.type.decode('utf-8'), bbndk) | |||
|
|
|||
| retCode = 1 | |||
| if (args.command == 'build'): | |||
| if (pos_args[0] == 'build'): | |||
There was a problem hiding this comment.
Bring back the following instead of using pos_args[0]
parser.add_argument('command', choices=['build', 'run'], help='commands')
There was a problem hiding this comment.
OptionParser doesn't support such format, it allows only options. In order not provide something like this --command before 'build' or 'run' commands we need to have them positional.
|
Reviewed |
Reviewers: DavidL, JP ChangeLog: - Convert argparse to optparse for builder.py script Test Cases: - Create sample project. - Run builder.py script with 'build' command - Make sure project successfully built. - Run builder.py script with 'run' command - Make sure project successfully ran. - Make sure script gives usage string in cases of missed or invalid argument - Make sure script launches application when device password set in command - Make sure script launches application when device password set in command - Make sure script fails to launch application when device password not set - Make sure script fails to launch application when invalid or incorrect ip
|
Updated |
| @@ -80,39 +81,51 @@ def error(msg): | |||
|
|
|||
| if __name__ == "__main__": | |||
|
|
|||
| # Setup script usage | |||
| parser = argparse.ArgumentParser(usage='<command> -t TYPE -d PROJECT_PATH -p NDK_PATH') | |||
| # Setup script usage using argparse | |||
|
Approved (with typo fixed before merge). |
| # Setup script usage | ||
| parser = argparse.ArgumentParser(usage='<command> -t TYPE -d PROJECT_PATH -p NDK_PATH') | ||
| # Setup script usage using argparse | ||
| parser = OptionParser(usage='<command: build | run> -t TYPE -d PROJECT_PATH -n NDK_PATH -i IP_ADDRESS [-p DEVICE_PASSWORD]') |
There was a problem hiding this comment.
-i IP_ADDRESS should be optional as it's only needed for the run command
NDK_PATH also was optional before and should still be
|
Reviewed |
|
|
||
| runGroup = parser.add_option_group('Run/Deploy options') | ||
| runGroup.add_option('-i', '--ip_address', help='(simulator | device) ip address', dest='ip_address') | ||
| runGroup.add_option('-p', '--device_password', help='(simulator | device) protection password', dest='device_password') |
There was a problem hiding this comment.
The change of short option name that you did in an earlier patch needs to be reverted as it break compatibility with the Studio. I thought they would code to the long options but they coded to the short ones instead.
Specifically -p needs to stay associated with --ndk_path
added 2 commits
June 7, 2012 14:14
…berry' into optparseBranch Conflicts: support/blackberry/builder.py
Reviewers: DavidL, JP ChangeLog: - Address comments Test Cases: - Create sample project. - Run builder.py script with 'build' command - Make sure project successfully built. - Run builder.py script with 'run' command - Make sure project successfully ran. - Make sure script gives usage string in cases of missed or invalid argument - Make sure script launches application when device password set in command - Make sure script launches application when device password set in command - Make sure script fails to launch application when device password not set - Make sure script fails to launch application when invalid or incorrect ip
|
Merged with latest and updated. |
|
Approved |
1 similar comment
|
Approved |
alexandergalstyan
added a commit
that referenced
this pull request
Jun 7, 2012
TIMOB-9309: BlackBerry: Convert argparse to optparse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: DavidL, JP
ChangeLog:
Test Cases: