TIMOB-9279: BlackBerry: Add --blackberry-device and --blackberry-password to drillbit #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word to drillbit [Issues Fixed] TIMOB-9279: BlackBerry: Add --blackberry-device and --blackberry-password to drillbit [Changes] drillbit.py - added usage blackberry.js - function BlackBerrySimulator - store the blackberry args - function createDeviceManagementProcess - replace the unused args with the used ones - functions isTestHarnessRunning, pushTestJS, launchTestHarness, killTestHarness - use the builder process instead of devicemanagement builder.py - functions __init__, __name__ - add useLogFile param to direct output to log file or stdout based on the command - function run - move the package name to a reusable function getPackage - added functions terminateApp, isAppRunning, printExitCode, getFile, putFile, appLog - function __name__ - added usage, options, and handling for the new commands devicemanagement.py - use optparse instead of argparse - move package-related commands to builder.py [Tests] Test 1: Run drillbit 1) Run scons to build the mobile sdk 2) Run the following command: drillbit\drillbit.py --platforms=blackberry --blackberry-device=<ip address> 3) Click "run tests" 4) Verify the test_harness app is built, deployed, and run 5) Verify the logs are printed Note: The test will fail because some things aren't implemented
| parser.add_argument('-t', '--type', choices=['simulator', 'device', 'deploy'], required=True) | ||
| parser.add_argument('-d', '--project_path', help='project directory path', required=True) | ||
| parser.add_argument('-p', '--ndk_path', help='blackberry ndk path') | ||
| parser = OptionParser() |
There was a problem hiding this comment.
Don't we need usage string here to provide more descriptive message rather than "devicemanagement.py [options]"
|
Reviewed |
…word to drillbit fix usage and required
|
Updated patch |
|
Approved |
1 similar comment
|
Approved |
dlifshitz-maca
added a commit
that referenced
this pull request
Jun 15, 2012
TIMOB-9279: BlackBerry: Add --blackberry-device and --blackberry-password to drillbit [Issues Fixed] TIMOB-9279: BlackBerry: Add --blackberry-device and --blackberry-password to drillbit [Changes] drillbit.py - added usage blackberry.js - function BlackBerrySimulator - store the blackberry args - function createDeviceManagementProcess - replace the unused args with the used ones - functions isTestHarnessRunning, pushTestJS, launchTestHarness, killTestHarness - use the builder process instead of devicemanagement builder.py - functions __init__, __name__ - add useLogFile param to direct output to log file or stdout based on the command - function run - move the package name to a reusable function getPackage - added functions terminateApp, isAppRunning, printExitCode, getFile, putFile, appLog - function __name__ - added usage, options, and handling for the new commands devicemanagement.py - use optparse instead of argparse - move package-related commands to builder.py [Tests] Test 1: Run drillbit 1) Run scons to build the mobile sdk 2) Run the following command: drillbit\drillbit.py --platforms=blackberry --blackberry-device=<ip address> 3) Click "run tests" 4) Verify the test_harness app is built, deployed, and run 5) Verify the logs are printed Note: The test will fail because some things aren't implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, Harut
Note: devicemanagement.py has been gutted in preparation for TIMOB-9378