TIMOB-9546: BlackBerry: Implement Platform elements needed for KitchenSink #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nSink
Reviewers: DavidC, JP
ChangeLog:
- Update Platform.yml apidoc.
- Added NativePlatformInterface to support native platform stuff.
- Implemented batteryLevel, batteryState, osname, name, runtime properties.
- Added constants describing battery states.
- Added TiPlatform class storing all Platform properties.
- Added methods to TiPropertyMapObject for adding properties with getter callback.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
#Some more info....
| @@ -52,6 +53,7 @@ methods: | |||
| - name: url | |||
| summary: The url to open. | |||
| type: String | |||
| platforms: [android, iphone, ipad, mobileweb] | |||
There was a problem hiding this comment.
openURL is part of this Jira task
There was a problem hiding this comment.
openURL already not part of app.js and doesn't prevent us from running KS. Also we don't have browser for now. That's why it leaved for near future.
There was a problem hiding this comment.
Please put a comment in the Jira
|
Reviewed |
…nSink ver2
Reviewers: DavidC, JP
ChangeLog:
- Update Platform.yml apidoc.
- Address comments.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
|
Updated |
| static vector<NATIVE_PROPGET_CALLBACK> initFunctionMap() | ||
| { | ||
| vector<NATIVE_PROPGET_CALLBACK> vect; | ||
| vect.resize(N_PLATFORM_PROP_LAST); |
There was a problem hiding this comment.
Pass the size in the constructor.
There was a problem hiding this comment.
Why we would need that?
There was a problem hiding this comment.
We use it just ones. Nothing we achieve from that rather, than have extra unusable variable.
There was a problem hiding this comment.
Maybe we're talking about different things :) This is what I mean:
vector<NATIVE_PROPGET_CALLBACK> vect(N_PLATFORM_PROP_LAST);
|
Reviewed |
…nSink ver3
Reviewers: DavidC, DavidL
ChangeLog:
- Address comments.
- Make BatteryInfo class member.
- Rename TiPlatform to TiPlatformObject.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
|
Updated. |
|
approved |
| PROP_GETTER(getBatteryLevel) | ||
| Handle<Value> NativePlatformInterface::getBatteryLevel() | ||
| { | ||
| return v8::Integer::New(NativePlatformInterface::instance()->batteryInfo_.level()); |
There was a problem hiding this comment.
No need for NativePlatformInterface::, you can call instance() directly
|
Approved with comments |
…nSink ver4
Reviewers: DavidC, DavidL
ChangeLog:
- Address comments.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
|
Updated. |
…nSink ver5
Reviewers: DavidC, DavidL
ChangeLog:
- Address comments.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
…berry' into platformBranch #Some more info....
…berry' into platformBranch Conflicts: blackberry/tibb/TiTitaniumObject.cpp
|
Updated and merged. |
…nSink ver5
Reviewers: DavidC, DavidL
ChangeLog:
- Fix conflicts with GET_PROPERTY_CALLBACK.
Test Cases:
- Run tibbtest.
- Make sure implemented properties: batteryLevel, batteryState, osname, name, runtime (as well as their getters) works succesfully.
- Use the following app.js snippet:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////
|
Fixing conflicts with GET_PROPERTY_CALLBACK |
|
Approved |
1 similar comment
|
Approved |
Larochelle
added a commit
that referenced
this pull request
Jul 9, 2012
TIMOB-9546: BlackBerry: Implement Platform elements needed for KitchenSink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: DavidC, DavidL
ChangeLog:
Test Cases:
////////////////////////////////////////
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
font: {fontSize:12},
color:'green',
top: 200
});
label1.text = Ti.Platform.batteryLevel.toString();
// label1.text = Ti.Platform.getOsname();
// label1.text = Ti.Platform.runtime;
// label1.text = Ti.Platform.getName();
// label1.text = Ti.Platform.getBatteryState().toString();
win1.add(label1);
// open window
win1.open();
////////////////////////////////////////