Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-9805 Blackberry: Implement UI.View.show #88

Merged
merged 2 commits into from Jul 6, 2012

Conversation

jpl-mac
Copy link

@jpl-mac jpl-mac commented Jun 29, 2012

Reviewers: Harut, DavidL

Changelog:

  • Implement show
  • remove unused var warnings in TiUIBase

Tests:

  • merged in Dave's getChildren patch to fix the event handling
    -- Using an eventHandler, toggled between show and hide on UI Controls
    ==> Verify that hide and show functions work

Changelog:
- Implement show
- remove unused var warnings in TiUIBase

Tests:
- merged in Dave's getChildren patch to fix the event handling
-- Using an eventHandler, toggled between show and hide on UI Controls
==> Verify that hide and show functions work
@dlifshitz-maca
Copy link

For such a small patch, you could have also fixed all the warnings that TiUIBase.h touches.
Also, aren't we supposed to attach a sample app.js to the Jira these days?
Code looks fine but my attempts at testing have been unsuccessful.

@jpl-mac
Copy link
Author

jpl-mac commented Jul 4, 2012

I posted the app.js I used to test this patch to https://jira.appcelerator.org/browse/TIMOB-9805.

It needs the getChildren patch from Dave to get the event handling to work (build is broken with it). I will add a merged commit here once the patch to fix the build has been merged in.

I will not modify the files that include TiUIBase.h as this patch is nowhere near them.

Conflicts:
	blackberry/tibb/TiUIBase.cpp
	blackberry/tibb/TiUIBase.h
@jpl-mac
Copy link
Author

jpl-mac commented Jul 4, 2012

Merged with blackberry, the app.js from the jira issue works on this branch now

@dlifshitz-maca
Copy link

Approved

@Harutyun
Copy link

Harutyun commented Jul 6, 2012

Approved with comments

@jpl-mac
Copy link
Author

jpl-mac commented Jul 6, 2012

Harut,

Comments are on the merge commit, that code is already committed and outside the scope of this patch. As there is nothing major i will not address in this PR.

jpl-mac pushed a commit that referenced this pull request Jul 6, 2012
TIMOB-9805 Blackberry: Implement UI.View.show
@jpl-mac jpl-mac merged commit a80ea2a into Macadamian:blackberry Jul 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants