TIMOB-9843: BlackBerry: Package framework's .js files #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-9843: BlackBerry: Package framework's .js files [Added] bootstrap.js [Changes] package.py - funcation zipBlackberryDir - also package .js files in the SDK blackberryndk.py - function package - copy the framework's JavaScript and package them in the .bar file [Tests] Test 1: Build Mobile SDK and an app 1) Run scons 2) Verify the build succeeds and the framework's .js files are in the Mobile SDK .zip file 3) Extract the Mobile SDK .zip file and create a project using project.py 4) Build and package/run the app 5) Verify the framework's .js files are in the .bar file
| * Copyright (c) 2009-2012 by Appcelerator, Inc. All Rights Reserved. | ||
| * Licensed under the terms of the Apache Public License | ||
| * Please see the LICENSE included with this distribution for details. | ||
| */ |
There was a problem hiding this comment.
I'm not convinced about the location of that file. seems like doing so will put us in a situation where the we have a src folder but all the c++ source files are outside of it. Maybe we just need a js folder?
There was a problem hiding this comment.
As discussed, I moved bootstrap.js to where it would be for TIMOB-9228
|
Let's discuss the location comment. But otherwise this patch is good. |
|
Approved. Test is pass. |
moved bootstrap.js
dlifshitz-maca
added a commit
that referenced
this pull request
Jul 6, 2012
TIMOB-9843: BlackBerry: Package framework's .js files [Issues Fixed] TIMOB-9843: BlackBerry: Package framework's .js files [Added] bootstrap.js [Changes] package.py - funcation zipBlackberryDir - also package .js files in the SDK blackberryndk.py - function package - copy the framework's JavaScript and package them in the .bar file [Tests] Test 1: Build Mobile SDK and an app 1) Run scons 2) Verify the build succeeds and the framework's .js files are in the Mobile SDK .zip file 3) Extract the Mobile SDK .zip file and create a project using project.py 4) Build and package/run the app 5) Verify the framework's .js files are in the .bar file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Harut, JP