TIMOB-9876: BlackBerry: Fix build failure #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: JP, David L Change Log: - removed nativeObjectFactory from constructor Test Cases: - build tibb - build should succeed Jira Bug: https://jira.appcelerator.org/browse/TIMOB-9876
| @@ -9,7 +9,7 @@ | |||
| #include "TiGenericFunctionObject.h" | |||
|
|
|||
| TiUIPicker::TiUIPicker(NativeObjectFactory* nativeObjectFactory) | |||
There was a problem hiding this comment.
The ctor shouldn't have the object factory as a param now that it doesn't use it anymore. It should get set directly in the createPicker function using setNativeObjectFactory
|
reviewed |
|
Approved (with JP's comment) |
|
Approved |
dcampbell-macadamian
added a commit
that referenced
this pull request
Jul 4, 2012
TIMOB-9876: BlackBerry: Fix build failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: JP, David L
Change Log:
Test Cases:
Jira Bug: https://jira.appcelerator.org/browse/TIMOB-9876