TIMOB-9897 Blackberry: address comments from Martin's review #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to address comments from Martin. JIRA issues have been created to track omments that require more time to resolve. Changelog: - created enum for NATIVE_ERROR for consistency with the rest of the file - added comment in NativeObjectFactory::createNativeObject stating where the created instances live and get deleted - added deleteInstance function to NativeStringInterface so we can delete it at shutdown time - added comment to empty methods onCreateStaticMembers and onSetProperty in TiObject class - added comment for overriding onSetProperty in .h - moved using namespace lines from TiV8EventContainer.h to cpp - removed unneeded forward declaration of TiInternalEventListener - moved TiInternalEventListener comment just before class declaration - release the TiRootObject at the end of script execution so it gets deleted properly - Added asset path to the js scripts for tibbtest Tests: - Built and ran app.js (provided in JIRA ticket) => Made sure that the event handling still works => Used String.format to make sure the modification to delete the instance didn't break it => Verified that the deleteInstance code gets invoked when during the app shutdown, using debug logs
|
Approved |
1 similar comment
|
Approved |
Larochelle
added a commit
that referenced
this pull request
Jul 9, 2012
TIMOB-9897 Blackberry: address comments from Martin's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: DC, Alex
This patch is to address comments from Martin. JIRA issues have been created to track omments that require more time to resolve.
Changelog:
Tests:
=> Made sure that the event handling still works
=> Used String.format to make sure the modification to delete the instance didn't break it
=> Verified that the deleteInstance code gets invoked when during the app shutdown, using debug logs