TIMOB-9455: BlackBerry: Add multiple unit type for width and height prop... #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties (work in progress) Reviewers: David L, Harut Change Log: - added support for width/height in mm - added support for width/height in cm - added support for width/height in inches Test Cases: - build tibb - build tibbtest - slider should be 100mm wide https://jira.appcelerator.org/browse/TIMOB-9455
updated API document fixed formatting
| @@ -16,6 +16,17 @@ | |||
| #include <bb/cascades/Color> | |||
| #include <bb/cascades/Container> | |||
| #include <qtgui/QColor> | |||
| #include <bb/device/DisplayManager> | |||
| #include <bb/device/Display> | |||
There was a problem hiding this comment.
fix order: Container, Display, DisplayManager, qColor (no need for the qtgui part)
|
Reviewed. |
|
Reviewed |
|
updated |
|
The widths on the simulator are still not the same as the device, but it's much better. |
Conflicts: blackberry/tibb/NativeControlObject.cpp
dcampbell-macadamian
added a commit
that referenced
this pull request
Jul 17, 2012
TIMOB-9455: BlackBerry: Add multiple unit type for width and height prop...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...erties (work in progress)
Reviewers: David L, Harut
Change Log:
Test Cases:
https://jira.appcelerator.org/browse/TIMOB-9455