Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlParseEntityDecl: entity xhtml-qname-extra.mod not terminated #2225

Closed
d-torrance opened this issue Sep 4, 2021 · 9 comments
Closed

xmlParseEntityDecl: entity xhtml-qname-extra.mod not terminated #2225

d-torrance opened this issue Sep 4, 2021 · 9 comments

Comments

@d-torrance
Copy link
Member

On today's amd64 PPA build of the development branch in Ubuntu 21.10, the validate-html check failed:

/usr/bin/make -C M2 validate-html
make[2]: Entering directory '/<<BUILDDIR>>/macaulay2-1.18.0.1+git202109031258/M2'
-- validating all html and xhtml files in /<<BUILDDIR>>/macaulay2-1.18.0.1+git202109031258/M2/usr-dist/common/share/doc/Macaulay2
validating: BGG/html/_direct__Image__Complex.html
 *** invalid HTML: /<<BUILDDIR>>/macaulay2-1.18.0.1+git202109031258/M2/usr-dist/common/share/doc/Macaulay2/BGG/html/_direct__Image__Complex.html
error: line 338: xmlParseEntityDecl: entity xhtml-qname-extra.mod not terminated

...

validating: AlgebraicSplines/html/index.html
 *** invalid HTML: /<<BUILDDIR>>/macaulay2-1.18.0.1+git202109031258/M2/usr-dist/common/share/doc/Macaulay2/AlgebraicSplines/html/index.html
error: line 338: xmlParseEntityDecl: entity xhtml-qname-extra.mod not terminated

9328 HTML files checked; 9328 invalid
make[2]: *** [GNUmakefile:302: validate-html] Error 1
@DanGrayson
Copy link
Member

Can you show us the html file?

@d-torrance
Copy link
Member Author

Can you show us the html file?

It's all 9328 html files in the documentation! It only failed in Ubuntu 21.10 -- the other builds were fine. I don't have any artifacts from the failed build, but I'll see if I can reproduce it locally.

@DanGrayson
Copy link
Member

All? It looks like just 2, including common/share/doc/Macaulay2/AlgebraicSplines/html/index.html.

@d-torrance
Copy link
Member Author

d-torrance commented Sep 4, 2021

All? It looks like just 2, including common/share/doc/Macaulay2/AlgebraicSplines/html/index.html.

I snipped out the middle 9326 failing files from the log before pasting, replacing them with ....

@DanGrayson
Copy link
Member

Ah, indeed: "9328 invalid".

I looked at common/share/doc/Macaulay2/AlgebraicSplines/html/index.html, which is supposed to have an error at line 338, and it has only 201 lines.

Maybe the xhtml validator on that machine is faulty, and you should just not bother checking the html. That's not the kind of thing that's going to depend on the architecture or the OS, anyway.

@d-torrance
Copy link
Member Author

Maybe the xhtml validator on that machine is faulty, and you should just not bother checking the html. That's not the kind of thing that's going to depend on the architecture or the OS, anyway.

Yeah, the html is only checked when building the architecture-independent macaulay2-common package, which only happens on amd64 PPA builds.

My guess is some dependency of the html validator was just updated in Ubuntu 21.10 or something. I'll try to track it down.

@d-torrance
Copy link
Member Author

I think I've tracked it down -- a new version of the libxml2 package was just uploaded to Debian unstable on Sep. 1 and it migrated over to Ubuntu 21.10 this morning.

I think this is totally unrelated to the Macaulay2 documentation -- I got the same error on another html file. Closing -- sorry for the noise!

@d-torrance
Copy link
Member Author

Indeed, it's already been reported as a bug against the Debian libxml2 package - https://bugs.debian.org/993638.

@mapreri
Copy link

mapreri commented Sep 20, 2021

JFYI, it's a different bug from the one linked above. It's currently tracked at https://bugs.debian.org/994765 and https://gitlab.gnome.org/GNOME/libxml2/-/issues/306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants