Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulations test failures with TOPCOM 1.1.2 #2704

Closed
d-torrance opened this issue Nov 30, 2022 · 0 comments
Closed

Triangulations test failures with TOPCOM 1.1.2 #2704

d-torrance opened this issue Nov 30, 2022 · 0 comments

Comments

@d-torrance
Copy link
Member

@mikestillman -- I'm getting two test failures with the new Triangulations package when running TOPCOM version 1.1.2:

check(1, "Triangulations")

assert(regularTriangulationWeights T == {1,1,0,0,0})

With TOPCOM 1.1.2, we get:

i48 : regularTriangulationWeights T

       1  1
o48 = {-, -, 0, 0, 0}
       2  2

o48 : List

I'm nowhere close to an expert in this area -- are these two weight vectors equivalent?

Note also that this test is essentially identical to the second part of the previous test -- do we need to run this twice? I'd actually removed the assert from the previous test when it was a Topcom package test for exactly this reason -- see c949ac2.

check(2, "Triangulations")

naiveIsTriangulation T -- TODO: doc this, and allow A to be homogenized? Same with topcomIsTriangulation

With TOPCOM 1.1.2, we get:

i59 : naiveIsTriangulation T
stdio:38:1:(3): error: array index 0 out of bounds 0 .. -1

Debugging, we see that this is coming from here:

../src/macaulay2/M2/M2/Macaulay2/packages/Topcom.m2:196:30:(2):[9]: error: array index 0 out of bounds 0 .. -1
../src/macaulay2/M2/M2/Macaulay2/packages/Topcom.m2:196:30:(2):[9]: --entering debugger (type help to see debugger commands)
../src/macaulay2/M2/M2/Macaulay2/packages/Topcom.m2:196:30-196:36: --source code:
    s = if match(///^C\[///, first s) -- TOPCOM >= 1.1.0

ii64 : s

oo64 = {}

oo64 : List

This is because chirocircuits from TOPCOM 1.1.2 didn't write anything to stdout:

$ chiro2circuits < /tmp/M2-2196909-0/122.in 2> /dev/null

Contrast this with TOPCOM 0.17.8:

$ chiro2circuits < /tmp/M2-2196909-0/122.in 2> /dev/null
5,4:
{
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant