Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test -e instead of AC_CHECK_FILE for cross building. #4

Merged
merged 1 commit into from May 26, 2020

Conversation

d-torrance
Copy link
Member

Patch by Helmut Grohne helmut@subdivi.de for Debian bug #941402 [1].

memtailor fails to cross build from source, because it abuses
AC_CHECK_FILE. The macro is meant to check for files on the host system,
but memtailor uses it to check for files expected on the build system.
Please use a simple test -e for the latter. Please consider applying the
attached patch.

[1] https://bugs.debian.org/941402

Patch by Helmut Grohne <helmut@subdivi.de> for Debian bug #941402 [1].

> memtailor fails to cross build from source, because it abuses
> AC_CHECK_FILE. The macro is meant to check for files on the host system,
> but memtailor uses it to check for files expected on the build system.
> Please use a simple test -e for the latter. Please consider applying the
> attached patch.

[1] https://bugs.debian.org/941402
@mikestillman
Copy link
Member

Patch by Helmut Grohne helmut@subdivi.de for Debian bug #941402 [1].

memtailor fails to cross build from source, because it abuses
AC_CHECK_FILE. The macro is meant to check for files on the host system,
but memtailor uses it to check for files expected on the build system.
Please use a simple test -e for the latter. Please consider applying the
attached patch.

[1] https://bugs.debian.org/941402

@d-torrance Sorry, I had not noticed this pull request. Do you have other changes to make from your recent debian porting work? I will accept this pull request if it is still relevant and you are ready.

@d-torrance
Copy link
Member Author

No worries!

Yes, it's still relevant. I don't have anything else. This is the only thing that's currently getting patched in the Debian package.

Thanks!

@DanGrayson
Copy link
Member

What cross-compilation are you doing, Doug?

@d-torrance
Copy link
Member Author

I'm not doing any myself, but there are Debian folks that do and submit patches like this. Debian makes releases for a bunch of architectures, and I suppose it makes some sense to do some cross builds to help facilitate that. Here's a list of the various builds for memtailor: https://buildd.debian.org/status/package.php?p=memtailor

@mikestillman mikestillman merged commit 1d13f96 into Macaulay2:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants