-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ascii art positioning #183
Comments
This is interesting, we could definitely do this :) |
Just had an afterthought about that feature-request, so I'll just leave that here as a brain-dump, it may be a bit overkill (?) Additionally to the positioning, specifying the alignment could also be pretty cool. Alignment could for example be an enum of: [custom_ascii]
# Possible values: start, center, end
# Default value: start
alignment = "center" Example for what I mean:
If the textbox is larger than the ascii image, then the alignment could be applied to the box instead. |
@123marvin123 How feasible would this be with the current structure? |
It shouldn't be too hard, I think, but some things would need to be refactored to allow such a placement. Right now, we are using the ASCII art on the left side of the screen as an anchor to align the actual readout information. I am currently too busy to work on this, maybe you can give it a try? |
Totally, just needed to know how big of a task this would be. |
Can we please make this feature also include a way to disable the image as well? I like the information, but don't need the image, which also don't render well on my light-themed terminal. |
If you're looking to disable ASCII art, just set |
We're no longer accepting feature requests, sorry. |
I've glanced over the theme documentation and I don't think there's this possibility yet.
Add a setting to specify the position where the ascii art should be displayed. Currently, it always displays on the left.
I have a fairly wide but short ascii art I'd like to use, it would look best if it was above the system info box.
Having a wide ascii art side by side with the system info doesn't work well in narrow terminal windows.
Something like:
The text was updated successfully, but these errors were encountered: