Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical Glitches, MC 1.5.2 + Playclaw 4 + keybinds #273

Closed
Zshazz opened this issue May 20, 2013 · 5 comments
Closed

Graphical Glitches, MC 1.5.2 + Playclaw 4 + keybinds #273

Zshazz opened this issue May 20, 2013 · 5 comments

Comments

@Zshazz
Copy link

Zshazz commented May 20, 2013

Greetings,

I've been having an issue with Powersuits under a particular set of conditions.

Running Minecraft 1.5.2
Forge 703 (tried many other versions, same deal)
Powersuits 514 (also tried many other versions, including 489 and 508)
Playclaw 4 game recording software

The important points are that it occurs in Minecraft 1.5.2 and with Playclaw4 running and with any keybindings set up in the powersuit. I'm guessing it has something to do with the way Playclaw hooks in. Fraps, for instance, does not cause the issue.

If config/powersuits-keybinds.cfg exists (for instance, with a keybinding to "c" or "f") when the game starts certain graphical glitches occur in gameplay. The graphical glitches include items not showing up in inventory and items not showing up in gameworld (and modules not showing up in the "k" menu)

Deleting config/powersuits-keybinds.cfg temporarily fixes the problem the next time the game is ran. You can set keybindings in-game without issue as the bug only presents itself when the file exists when the game starts.

If more mods are added (not sure which causes it yet), the following message appears in the console:

[SEVERE] [Minecraft-Client] ########## GL ERROR ##########
[SEVERE] [Minecraft-Client] @ Pre render
[SEVERE] [Minecraft-Client] 1281: Invalid value

If it helps, my theory is that another mod outputs the above message because it failed to render because of Powersuits' bug because the minimal repro steps listed above seem to not have this message appear (which means that the number of mods is minimized, so few chances of them failing to render and output that message).

Anyway, I hope that was helpful. I'll continue to research this problem and I might update this report with my findings. If you are unable to reproduce this for any reason but think you may have a fix, I can try it out for you and let you know.

Take care

@Zshazz
Copy link
Author

Zshazz commented May 20, 2013

I do want to note that Issue #272 mentioned this problem occurring, but I think it was orthogonal to the issue he was reporting.

@MachineMuse
Copy link
Owner

I can't debug your screen capture software, dear.

@Zshazz
Copy link
Author

Zshazz commented May 20, 2013

Clair, you might want to read some of these bug reports sometime. I'm not asking you to "debug my screen capture software", and don't call me "dear". I don't appreciate responses like that after spending my time writing a detailed bug report where I eliminate superfluous information and minimize the reproduction steps. Yes, this bug manifests while I use Playclaw, but it could just as easily have been another piece of software. I could have just said "it spits this error out and I have 10 mods running plz fix" and not spent my precious time trying to help you fix it. Would you rather someone else who ISN'T a programmer send you the bug reports later or would you rather me send you a bug report as I actually work on it?

Anyway, Just giving you an update:

Modifying the code to exclude KeybindManager.readInKeybinds(); in registerHandlers in ClientProxy.java does indeed fix the issue as I thought it might. However, obviously, this means that keybindings are not loaded until the user presses k in game (which causes them to load). So something in readInKeybinds is clearly doing something that Minecraft doesn't like having happen before the title screen shows up. I'm not an expert by any means with modding Minecraft, but my next step is to see if I can figure out a way to load up keybindings only when a player enters a server.

@MachineMuse
Copy link
Owner

You stated it only occurs when using your screen capture software. Downloading a 3rd-party tool I've never heard of is not a reproduction step I'm willing to follow. I'm sorry if you consider that a reasonable request, but in my opinion a certain degree of condescension was warranted.

@Zshazz
Copy link
Author

Zshazz commented May 20, 2013

No, I stated it only occurs when using MC 1.5.2 AND config/powersuits-keybinds.cfg exists AND Playclaw 4 was running. If I use MC 1.5.1 the problem goes away and if I delete config/powersuits-keybinds.cfg then the problem also goes away, so it's an interaction between all of these factors. I was only willing to work on it because I though Issue #272 might be related and it might be affecting other users who were not using Playclaw.

However, my desire to contribute has now waned. The fix I mentioned above is acceptable for my purpose (pressing 'k' is not much of an inconvenience, and commenting out a single line of code is trivial). I'll refrain from making the mistake of attempting to make future contributions to your projects.

Perhaps you should consider no degree of condescension to be warranted in the future to avoid scaring off more contributors.

Good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants