Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add this pull request: #83 #86

Closed
ioanrobciuc opened this issue Mar 8, 2016 · 5 comments
Closed

Add this pull request: #83 #86

ioanrobciuc opened this issue Mar 8, 2016 · 5 comments
Assignees
Milestone

Comments

@ioanrobciuc
Copy link
Contributor

Add this pull request: #83.

@ioanrobciuc ioanrobciuc self-assigned this Mar 8, 2016
@ioanrobciuc ioanrobciuc added this to the 3.12.0 milestone Mar 8, 2016
ioanrobciuc pushed a commit that referenced this issue Mar 8, 2016
@alanorth
Copy link

alanorth commented Mar 8, 2016

You guys are doing some weird stuff with this theme, and the git / GitHub workflow. So I open an issue (#82), and you ask me to create a pull request. I write the code and create a pull request (#83), and you guys commit my code as your own without attribution?

It's as simple as pressing the big green button on the pull request, or cherry-picking the commit from my branch in the git command line if you don't want to use GitHub workflow. What's up?

Does @ScottSmith95 know about this bizarre behavior?

@ioanrobciuc
Copy link
Contributor Author

@alanorth, next time do pull request to "development" branch please. I'm sorry for inconvenience.

@alanorth
Copy link

alanorth commented Mar 8, 2016

I don't REALLY care about the commit attribution, it's just a funny behavior on your part. You could have either asked me to re-do the pull request if you honestly wanted my contribution, or if you were living in "real" git land you could have simply cherry picked my commit from my branch and the closed the issue/pull request.

@cristianraiber
Copy link
Collaborator

@alanorth sorry about this. We're kind of new to the git workflow, so mistakes can happen on our part. Again, really sorry.

@alanorth
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants