Substructure to Shared Library #63
Conversation
jackaraz
added
⚙️enhancement
* add CXX11 and fPIC flags * enable all plugins
| theCommands=['./configure','--fastjet-config='+self.bindir] | ||
| # TODO: figure out how to give `-std=c++11 -fPIC` together to CXXFLAGS | ||
| # using " or ' doesn't work on linux systems | ||
| theCommands = ['./configure', '--fastjet-config=' + self.bindir, 'CXXFLAGS=-fPIC'] |
There was a problem hiding this comment.
TODO: fjcontrib still needs to be compiled with CXXFLAGS="-std=c++11 -fPIC"; however couldn't figure out how to feed them together to the terminal. The configuration file doesn't accept " or ' through the python interface, although both work when done by hand.
There was a problem hiding this comment.
yeap didn't work for me even tried the Unicode string :/
|
Hi Jack. Can you please first resolve the conflicts before I start reviewing this branch? Thanks in advance! |
The conflict has been resolved. |
Great. Starting the review! |
|
|
||
| // set top mass ratio range | ||
| MAfloat32 fw = 0.15; | ||
| MAfloat32 mass_ratio_range_min = (1-fw)*80.379/172.9; |
There was a problem hiding this comment.
We need a function that updates this when the user change the mass of the top or the W boson.
Context:
This PR includes code flow optimization and compilation efficiency updates.
PR also includes additional functionality to detect fastjet contrib and HTT to compile MadAnalysis accordingly.