This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
build(prebuild): update prebuild dependencies to latest #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2020
Closed
|
Thanks for looking into this @mcous! Your explanation makes sense to me and might as well give it a shot 🤘🤘 |
|
This is now part of v4.8.0 Going to wait for the prebuilds to build and publish to npm 🚀 |
This was referenced Apr 24, 2020
Closed
This was referenced Aug 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-abi, which is a dependency of prebuild and prebuild-install, contains the logic for which Node versions
prebuild --allcompiles for and subsequently publishes to GitHub releases.package-lock.jsonhad locked the version of node-abi to a version (2.2.0) from about 2 years ago, leading to a drastically outdated list of precompiled Node versions. This PR uninstalls and then reinstalls prebuild and prebuild-install to pick up the latest version of each as well as the latest version of node-abi.I haven't been able to get my computer's node-gyp set up properly, so I haven't been able to test this yet. But, if everything works out, I think this should fix #85 and fix #104