Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media query option to preserver order (default true) #100

Closed
wants to merge 3 commits into from

Conversation

patmead
Copy link

@patmead patmead commented May 13, 2019

This is an edit of @erikthalen's pull request to change the default value of the new option to true.

See: #92 (comment)

preserveInjectedVariables: true,
// Will write media queries in the same order as in the original file.
// Set it to true if you're working with min-width
preserveAtRulesOrder: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is still false here when it should be true

All of the test cases would need to be updated as well.

Copy link
Owner

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have a place to update the default to true

It would also be good to drop all of the playground/ changes so I can build them myself on master

@patmead
Copy link
Author

patmead commented May 27, 2019

Abandoned as per #92 (comment)

@patmead patmead closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants