Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overload Logging macros #154

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Do not overload Logging macros #154

merged 6 commits into from
Mar 25, 2022

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Mar 23, 2022

Solve #153

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #154 (b2041c4) into master (9c07280) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   74.46%   74.58%   +0.11%     
==========================================
  Files          32       32              
  Lines        3380     3380              
==========================================
+ Hits         2517     2521       +4     
+ Misses        863      859       -4     
Impacted Files Coverage Δ
lib/MadNLPHSL/src/ma86.jl 84.90% <0.00%> (+3.77%) ⬆️
src/MadNLP.jl 62.50% <ø> (ø)
lib/MadNLPPardiso/src/pardisomkl.jl 93.75% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c07280...b2041c4. Read the comment docs.

@sshin23
Copy link
Member

sshin23 commented Mar 25, 2022

@frapac I was working on making CI independent of MKL, so that we can use the fresh install of julia in every CI (#157). If it works out, I believe c498a88 is not necessary

@frapac
Copy link
Collaborator Author

frapac commented Mar 25, 2022

Ok, let me know if you want me to revert that commit!

@sshin23 sshin23 linked an issue Mar 25, 2022 that may be closed by this pull request
@sshin23 sshin23 merged commit 2ce0f48 into master Mar 25, 2022
@frapac frapac deleted the fp/logging branch October 4, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MadNLP breaks Julia logging macros
3 participants