[TTFS] Replace broadcast operators by explicit for loops in IPM kernels #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshin23
reviewed
Oct 19, 2022
There was a problem hiding this comment.
@frapac Thanks for working on this! Seems that this can significantly reduce the time. Though, I'd suggest we run a benchmark to better understand the impact on solution time.
Another suggestion, I think for many of these operations, @simd is applicable. Have you considered/tested this?
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 74.19% 75.74% +1.54%
==========================================
Files 38 38
Lines 3697 3512 -185
==========================================
- Hits 2743 2660 -83
+ Misses 954 852 -102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce drastically the precompile time.
On current master, we get
On this branch:
x-ref: #186