Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactive logs in benchmark scripts #59

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Aug 24, 2021

  • some minor formatting

@frapac frapac requested a review from sshin23 August 24, 2021 20:36
Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @frapac for the improvements! I was thinking that the user may want to see the progress of running the benchmark. Now that we don't print the solver output, maybe we can at least show which problem it is currently solving?

@sshin23
Copy link
Member

sshin23 commented Aug 24, 2021

other than that, everything looks good 👍

@frapac
Copy link
Collaborator Author

frapac commented Aug 24, 2021

Good point. I think we already have some information with: https://github.com/sshin23/MadNLP.jl/blob/master/benchmark/benchmark-power.jl#L42
But you are right: would you like me to add an option to active solver's log as well?

@sshin23
Copy link
Member

sshin23 commented Aug 24, 2021

Aha, yes you're right. And yes, I think it would be good to make it as a command line option.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #59 (9642f45) into master (d31692a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files          28       28           
  Lines        3018     3018           
=======================================
  Hits         2635     2635           
  Misses        383      383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31692a...9642f45. Read the comment docs.

@sshin23 sshin23 merged commit bd3da2f into MadNLP:master Aug 25, 2021
sshin23 pushed a commit to frapac/MadNLP.jl that referenced this pull request Aug 28, 2021
* deactive logs in benchmark scripts

* benchmark: add verbose option to main script
sshin23 added a commit that referenced this pull request Aug 29, 2021
* Add AbstractKKTSystem structure

* implement SparseReducedKKTSystem and SparseAugmentedKKTSystem
* refactor Solver

* Avoid unecessary allocations by forcing specialization

* Deactive logs in benchmark scripts (#59)

* deactive logs in benchmark scripts

* benchmark: add verbose option to main script

* barrier iterations (#61)

* benchmark improvement (#60)

* allocation issue fixed

* added option buffered for NLPModels.jl

* added option buffered for NLPModels.jl

* added option buffered for NLPModels.jl

* ma27 fix

Co-authored-by: Sungho Shin <sshin@anl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants