Add/link api #13
Add/link api #13
Conversation
| return senPostRequest(url, JSON.stringify(body)) | ||
| } | ||
|
|
||
| async updateLinkConfig (oldLinkName, config) { |
There was a problem hiding this comment.
why is this async and others are not?
| let connectorName | ||
| let jdbcDriver | ||
| let connectionString | ||
| let fetchSize = linkConfig.hasOwnProperty('fetchSize') ? linkConfig['fetchSize'] : 1000 |
There was a problem hiding this comment.
linkConfig('fetchSize') || 1000
| const port = linkConfig.hasOwnProperty('port') ? linkConfig['port'] : 3306 | ||
| connectorName = 'generic-jdbc-connector' | ||
| jdbcDriver = 'com.mysql.jdbc.Driver' | ||
| connectionString = 'jdbc:mysql://' + linkConfig['host'] + ':' + port + '/' + linkConfig['databaseName'] |
There was a problem hiding this comment.
you can use back tick to do string interpolation
| throw new Error('linkType must be mysql') | ||
| } | ||
| return { | ||
| 'links': [{ |
There was a problem hiding this comment.
是说除了mysql还有什么吗，还是mysql那个的配置是什么含义。前者的话，除了mysql，还有oracle, generic,sftp,kite,kafka,ftp,hdfs。mysql属于generic。我再加个hdfs。
| 'username': 'root', | ||
| 'password': '12343456', | ||
| } | ||
| await sqoopClient.updateLinkConfig(oldLinkName, config) |
There was a problem hiding this comment.
what is the return value of this update?
2 similar comments
| const linkName = 'test_link_2' | ||
| await sqoopClient.updateLinkEnable(linkName) | ||
| const data = await sqoopClient.getLinkByLinkName(linkName) | ||
| expect(data['links'][0]['enabled'].toString()).to.equal('true') |
…o Add/link-api
| async deleteLinkAll () { | ||
| const data = await this.getLinkAll() | ||
| const deleteList = data['links'].map(link => this.deleteLink(link['name'])) | ||
| return await deleteList |
There was a problem hiding this comment.
you should await Promise.all(a list of promise) not await a list of promise the latter does not work
…ad of mysql string
| } | ||
| ] | ||
| } | ||
| } else if (linkConfig['linkType'] === linkType.hdfs) { |
There was a problem hiding this comment.
tear up this into two smaller functions
| } | ||
|
|
||
| export function setCreateLinkRequestBody (linkConfig) { | ||
| if (linkConfig['linkType'] === linkType.mysql) { |
There was a problem hiding this comment.
use two separate functions for mysql and hdfs
| @@ -21,7 +30,7 @@ export class Hasoop { | |||
| } | |||
|
|
|||
| formatUrl ([basicPath, queryObject = {}], ...otherPath) { | |||
| queryObject['user.name'] = this.userName | |||
| _.set(queryObject, ['user.name'], this.userName) | |||
There was a problem hiding this comment.
i guess ['user.name'] can be user.name
There was a problem hiding this comment.
在lodash里面，它是以.分割的，如果直接写user.name的话，就会是user=，而不是user.name=<userName>
No description provided.