-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filehandling] add explicit "profile" attribute to audio/video Previews #15
Comments
@michalpodlecki I made it even simpler: You can rely that the new key will be the same as the codec so we can reuse the migration you already did – it's basically renaming the attribute if I am not mistaken. |
@eins78 yes, renaming would be enough. |
@michalpodlecki small addition: if you have to adapt all places that use that config anyhow, it's a good oppertunity to change that confusing name (minus |
@eins78 I agree 👍 |
…r jobs * collect conversion profiles for video previews and zencoder jobs
…r jobs * collect conversion profiles for video previews and zencoder jobs
…r jobs * collect conversion profiles for video previews and zencoder jobs
…r jobs * collect conversion profiles for video previews and zencoder jobs
for Previews with
media_type
:audio
andvideo
currently:
new:
There was already an attribute added which relates to the codec,
so to keep it simple we can rely on the following rules:
(Because multiple configs with same config are not supported yet, we can safely assume this.)
questions:
Name of the attribute?
conversion_profile
?preview_profile
?madek_preview_profile
?(Note that this is conceptually the same attribute as the
thumbnail
attr for Previews with media_type image, but we don't have to change that)tasks
deploy: change config for audio, video (array to map)
DB: migration audio
conversion_profile
attribute topreviews
conversion_profile
attribute for existingpreviews
(find profile according to the "codec" prop, "id" of profile is the key of config in the map)
DB: migration videos
conversion_profile
attribute topreviews
conversion_profile
attribute for existingpreviews
(find profile according to the "codec" prop, "id" of profile is the key of config in the map)
DB: migration zencoder_jobs ???
admin/webapp
The text was updated successfully, but these errors were encountered: