fix: sql-exception causes session-delete (back-button) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimaai
requested changes
Jun 12, 2024
spec/features/meta_keys_spec.rb
Outdated
| @@ -567,6 +567,9 @@ def meta_datum_types | |||
| expect(current_path).to eq(meta_key_path(meta_key)) | |||
| expect(meta_key.meta_data.reload).to eq(meta_data) | |||
|
|
|||
| visit meta_key_path("") | |||
There was a problem hiding this comment.
does this work? normally one should pass the meta_key to this path helper.
There was a problem hiding this comment.
Yes, fnc only adds meta_key to url /admin/meta_keys/
Both scenarios have been tested with binding.pry - with/out fix
There was a problem hiding this comment.
Replaced it by string-definition
SeduroDotCom
force-pushed
the
mr/fix-back-button
branch
from
da0a1f0
to
2f859f7
Compare
SeduroDotCom
force-pushed
the
mr/fix-back-button
branch
from
2f859f7
to
37fb287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.