Version 2 #1
Version 2 #1
Conversation
|
|
||
| export abstract class BaseMessageBus implements MessageBus { | ||
| protected handlersMap: HandlersMap = {}; | ||
| protected middlewareList: MessageBusMiddleware<any>[] = []; |
There was a problem hiding this comment.
Middlewares should match some interface. It can be a single functions where message is passed or classes with ex. handle function which accepts message as a parameter. For now if middleware class will not have a handle method handle will throw an error about calling undefined function.
| if (isMessageHandlerObject(args[0])) { | ||
| handler = args[0]; | ||
| type = handler.getSupportedType(); | ||
| } else { |
There was a problem hiding this comment.
Maybe else if? Here you can check if args[0] is a message.
| ? args[0].type | ||
| : args[0]; | ||
| handler = args[1]; | ||
| } |
There was a problem hiding this comment.
Here you can have an else statement and throw an error inside if type is not a string, or is empty. This will make this code more readable.
| } | ||
|
|
||
| if (!isMessageHandler(handler)) { | ||
| throw new Error('handler must be a function or an object of type MessageHandlerObject'); |
There was a problem hiding this comment.
Unify error messages. Handler must be.... Capital letters
| import {isMessageHandlerObject} from './TypeCheckers/isMessageHandlerObject'; | ||
|
|
||
| export abstract class BaseMessageBus implements MessageBus { | ||
| protected handlersMap: HandlersMap = {}; |
There was a problem hiding this comment.
Maybe you can use a Map here? It will add more typing to this class.
| await middleware.handle(message); | ||
| } | ||
|
|
||
| if (!this.handlersMap[type]) { |
There was a problem hiding this comment.
If you use a Map class in handlersMap you can assign handlers to const and check this condition.
| ): [string, MessageHandler<P>] { | ||
| const [type, handler] = this.getTypeAndHandlerFromArgs([arg1, arg2]); | ||
| if (this.handlersMap[type]) { | ||
| throw new Error('There can be only one handler per type in CommandBus'); |
There was a problem hiding this comment.
Why? I cannot handle the same message types in more than one place?
| const message2: Message<{lorem: string}> = {type: 'bar', payload: {lorem: 'ipsum'}}; | ||
|
|
||
| class TestMessage implements Message<{dolor: string}> { | ||
| readonly type: string; |
No description provided.