Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing build tools and minor code improvement #28

Merged
merged 4 commits into from Oct 25, 2018

Conversation

ligi
Copy link
Contributor

@ligi ligi commented Oct 19, 2018

it is easier to work with in newer AS versions this way

@instrap
Copy link
Member

instrap commented Oct 21, 2018

@thsaravana Could you check this and merge this if it's fine?

Copy link
Member

@thsaravana thsaravana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
In the lines of code improvement, there are still certain things that we need to do. But let's merge this, and I will take care of that. We anyways have to update the version.
Thanks for the PR by the way :)

@thsaravana thsaravana merged commit a3ced9f into Madrapps:master Oct 25, 2018
@ligi
Copy link
Contributor Author

ligi commented Oct 25, 2018

you are very welcome - really like the lib - use it in WallETH now - thanks for coding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants