Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework UI #110

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Rework UI #110

wants to merge 2 commits into from

Conversation

Deewarz
Copy link
Contributor

@Deewarz Deewarz commented Mar 15, 2024

Global

  • Add a way to disable processing of mouse and keyboard events
  • Add UIBase: base class for all UI to manage visibility, blocked controls, custom window (specific design when controls are locked)...

Console

  • Virtual extends from UIBase
  • Use custom window from UIBase (remove console-level window design when controls are locked in favor of global behavior)
  • Remove Multiline (not compatible with history: https://github.com/ocornut/imgui/blob/master/imgui_widgets.cpp#L4093)
  • Remove the control lock toggle in favor of global integration at project level
  • Improve design when controls unlocked (no scrollbar, no ghost spacing, padding fixes, ...)
  • Cleanup code (useless condition, variable names, indentation, ...)

@Deewarz Deewarz self-assigned this Mar 15, 2024
@Deewarz Deewarz marked this pull request as ready for review March 15, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant