Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON for ArraySerialized in Magento 2.2 #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use JSON for ArraySerialized in Magento 2.2 #11

wants to merge 2 commits into from

Conversation

atlan
Copy link
Contributor

@atlan atlan commented Oct 2, 2017

No description provided.

sydekumf
sydekumf requested changes Oct 5, 2017
View reviewed changes
Helper/Data.php
));
);

$objectManager = ObjectManager::getInstance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inject necessary classes via di.xml and constructor instead of the object manager :-)

@ghost ghost mentioned this pull request Dec 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydekumf sydekumf sydekumf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atlan @sydekumf