Add more default units #22 #38 - Add option to translate reference unit #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, can it be merged? |
|
@sippsolutions @wick-ed Any chances this will be merged? |
|
@sydekumf can you check it? |
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added km, qm, cbm, pc as default units. And for km the corresponding conversions. Additionally I changed
getReferenceUnitto return the reference unit as a Phrase so it can be translated. The translation is especially helpful in front end for non English stores because you can simply add the reference units to your dictionary for example to translate "pc" to "Stk.".After adding the options I sort the options in order to keep them grouped.