Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manage Banner" section pointing to BannerSlider #56

Open
rivaldoleon opened this issue Aug 31, 2016 · 9 comments
Open

"Manage Banner" section pointing to BannerSlider #56

rivaldoleon opened this issue Aug 31, 2016 · 9 comments

Comments

@rivaldoleon
Copy link

After a fresh install of the 1.7 version, I was able to create a new slider, but when a hit the "Manage Banner" I'm getting some errors. I've created a Bannerslider folder, but some sections of the code are referencing BannerSlider. I've just replaced all those entries with Bannerslider, and now works perfectly.

@friizu
Copy link

friizu commented Aug 31, 2016

Yes this was the issue, also fixes this:
#54

@friizu
Copy link

friizu commented Sep 2, 2016

List of files i replaced "BannerSlider" to "Bannerslider" (cause namespaces and class names are case sensitive), after replacements all works like a charm. Tested on version 2.1.1

Controller/Adminhtml/AbstractAction.php
Controller/Adminhtml/Banner/MassDelete.php
Controller/Adminhtml/Banner/MassDisable.php
Controller/Adminhtml/Banner/MassEnable.php
Controller/Adminhtml/Slider/MassDelete.php
Controller/Adminhtml/Slider/MassDisable.php
Controller/Adminhtml/Slider/MassEnable.php
Model/Data/Option/OptionHashInterface.php
Model/ResourceModel/Banner/Collection.php
Model/ResourceModel/Banner/Grid/Collection.php
Model/ResourceModel/Banner/Grid/StatusesArray.php
Model/ResourceModel/Report.php
Model/ResourceModel/Report/Grid/Collection.php
Model/ResourceModel/Slider/Grid/Collection.php
Ui/Component/Listing/Column/AbstractColumn.php
Ui/Component/Listing/Column/BannerstatusActions.php
Ui/Component/Listing/Column/Image.php
Ui/Component/Listing/Column/Slider.php
etc/di.xml
view/adminhtml/ui_component/banner_grid_listing.xml

@sgrspkt
Copy link

sgrspkt commented Sep 14, 2016

@friizu If i have my vendor_module name as Magestore_ Bannerslider, why do i change Bannerslider to BannerSlider ? The namespace depends on vendor_module name given on directory, right ?

@friizu
Copy link

friizu commented Sep 14, 2016

You are right, don't! I replaced "BannerSlider" to "Bannerslider" not other way around.

@sgrspkt
Copy link

sgrspkt commented Sep 14, 2016

@friizu if i have vendor_module name as Magestore_Bannerslider and namespaces as Bannerslider, the error is same, how can i solve the problem ??

@friizu
Copy link

friizu commented Sep 14, 2016

@sgrspkt - as on first post this thread and my previous post, you need to check all files I listed, for example:
Controller/Adminhtml/AbstractAction.php
line 173 you find:

$collection = $this->_objectManager->create('Magestore\BannerSlider\Model\ResourceModel\Banner\Collection');

You see path BannerSlider (what needs to be Bannerslider) and so on ... so you need to make replace to all those files to make this module work fluent.

ps. if u wanna make mass replace on those files be sure that you'r replace is case sensitive!

@sgrspkt
Copy link

sgrspkt commented Sep 15, 2016

@friizu, Thank you. I solved the problem of manage banner after replacing 'BannerSlider' with 'Bannerslider'.

@marcatos
Copy link

@sgrspkt here #66 (comment) you can find our implementation

@Vikram0811
Copy link

@friizu your solution worked for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants