Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to Python 3, attempt numero uno #114

Closed
wants to merge 37 commits into from
Closed

Migrating to Python 3, attempt numero uno #114

wants to merge 37 commits into from

Conversation

ianeli1
Copy link
Contributor

@ianeli1 ianeli1 commented Apr 25, 2022 •
edited

Overall:

  • Fixed most obvious problems with py2 to py3 migration
  • Updated imports for Django components that changed over time
  • Made a polyfill for string_concat
  • Assumed ugettext_lazy is the same as gettext_lazy since Py3 removed the need for unicode()
  • Swapped unicode with str
  • More stuff i forgot

Also, django-recaptcha3 is dead, been inactive since 2020. A replacement is needed. Patched out the imports for now so we can test if this works at all lol

@ianeli1 ianeli1 changed the title Way too many changes Migrating to Python 3, attempt numero uno Apr 25, 2022
@ianeli1
Replace all instances of ugettext_lazy
c892a84
@ianeli1
Rename MIDDLEWARE_CLASSES to MIDDLEWARE
f686669
@ianeli1
Replace unicode with str
46fff3c
@ianeli1
Migrations default to CASCADING
d66fb30
@ianeli1
Update middleware to use new mixin
a685423
@ianeli1
Remove method call as key is a property now
15a90e6
@ianeli1
Enforce typecasting to list
5e14d2f
@ianeli1
Remove deprecated method
81898ca
@ianeli1
Reimplement deprecated method
ce8315d
@ianeli1
Replace basestring with str
987a4aa
@ianeli1
Set a default value for request_tab
2a23ab6
@ianeli1
Remove recaptcha
679dce6
@ianeli1
Enforce passing a dict to render
8e3eb07
@ianeli1
Change method call to property access for is_authenticated
7fd964c
@ianeli1
Replace rel.to with remote_field.model
3a168d7
@ianeli1
Use new __code__ attr
6217cad
@ianeli1
Enforce list type casting
838ec09
@ianeli1
Remove unneeded type padding
71f62ac
@ianeli1
Disable whatever filter_form is lol
3c8c595
@ianeli1
Cast iterable into list
c4726e4
@ianeli1
Upgrade django-bootstrap-form
0ec6fb8
@ianeli1
Avoid division by zero
18a2728
@ianeli1
using language code from settings
ede15f1
@ianeli1
Add parenthesis to all prints
2ae5018
@ianeli1
Fix print 2.0
622f105
@ianeli1
Fix lambdas
2c4839f
@ianeli1
Cast to Py3 str
ad8d4f7
@ianeli1
Remove deprecated import of future
330c12b
@ianeli1 ianeli1 closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ianeli1