check module.module

MagicMirrorOrg · May 10, 2024 · 6647160 · 6647160
1 parent 3b00357
commit 6647160
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,8 @@ _This release is scheduled to be released on 2024-07-01._
 
 ### Fixed
 
+- Fix crash possibility if `module: <name>` is not defined
+
 ## [2.27.0] - 2024-04-01
 
 Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser, @khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and @vppencilsharpener.

diff --git a/js/app.js b/js/app.js
@@ -253,8 +253,10 @@ function App () {
 
 		let modules = [];
 		for (const module of config.modules) {
-			if (!modules.includes(module.module) && !module.disabled) {
-				modules.push(module.module);
+			if (module.module) {
+				if (!module.disabled) modules.push(module.module);
+			} else {
+				Log.warn("No module name found for this configuration:", module);
 			}
 		}
 

diff --git a/js/loader.js b/js/loader.js
@@ -50,7 +50,8 @@ const Loader = (function () {
 	 * @returns {object[]} module data as configured in config
 	 */
 	const getAllModules = function () {
-		return config.modules;
+		const AllModules = config.modules.filter(module => module.module !== undefined);
+		return AllModules;
 	};
 
 	/**