We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I just encountered an error regarding fetching a subscribed calendar. By debugging I could verify, that the issue is caused by the server, blocking requests based on matching Node.js in the User-Agent header. By reading through other issues i saw, that from time to time there have been some other issues regarding parts of the use agent (e.g. #2729 ). So I would suggest, to add a configuration option to optionally override the user-agent at least for default modules calendar and news (see https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/newsfeed/newsfeedfetcher.js#L105 and https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/calendar/calendarfetcher.js#L42 ). Other modules are then free to consume this option as well.
Node.js
User-Agent
If you agree on that, i won't mind to open a PR to tackle it.
The text was updated successfully, but these errors were encountered:
MagicMirrorOrg#3253 make User-Agent configurable
185c07d
make User-Agent configurable (MagicMirrorOrg#3253)
9c3e6e3
49c8353
No branches or pull requests
I just encountered an error regarding fetching a subscribed calendar. By debugging I could verify, that the issue is caused by the server, blocking requests based on matching
Node.js
in theUser-Agent
header. By reading through other issues i saw, that from time to time there have been some other issues regarding parts of the use agent (e.g. #2729 ).So I would suggest, to add a configuration option to optionally override the user-agent at least for default modules calendar and news (see https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/newsfeed/newsfeedfetcher.js#L105 and https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/calendar/calendarfetcher.js#L42 ).
Other modules are then free to consume this option as well.
If you agree on that, i won't mind to open a PR to tackle it.
The text was updated successfully, but these errors were encountered: