Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make User-Agent configurable #3253

Open
m-idler opened this issue Oct 26, 2023 · 0 comments
Open

Make User-Agent configurable #3253

m-idler opened this issue Oct 26, 2023 · 0 comments

Comments

@m-idler
Copy link

m-idler commented Oct 26, 2023

I just encountered an error regarding fetching a subscribed calendar. By debugging I could verify, that the issue is caused by the server, blocking requests based on matching Node.js in the User-Agent header. By reading through other issues i saw, that from time to time there have been some other issues regarding parts of the use agent (e.g. #2729 ).
So I would suggest, to add a configuration option to optionally override the user-agent at least for default modules calendar and news (see https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/newsfeed/newsfeedfetcher.js#L105 and https://github.com/MichMich/MagicMirror/blob/343e7de7bd295a69e68e4ee520552e0785a99e1c/modules/default/calendar/calendarfetcher.js#L42 ).
Other modules are then free to consume this option as well.

If you agree on that, i won't mind to open a PR to tackle it.

m-idler added a commit to m-idler/MagicMirror that referenced this issue Oct 31, 2023
m-idler added a commit to m-idler/MagicMirror that referenced this issue Oct 31, 2023
m-idler added a commit to m-idler/MagicMirror that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants