Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new electron tests supporting date mocking #2947

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Oct 15, 2022

first PR for #2942

…m `e2e` to `electron` because of date mocking, removed mock stuff from compliments module
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #2947 (397cb0d) into develop (7bbf8c1) will increase coverage by 1.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2947      +/-   ##
===========================================
+ Coverage    64.06%   65.28%   +1.22%     
===========================================
  Files            9       14       +5     
  Lines          295      726     +431     
===========================================
+ Hits           189      474     +285     
- Misses         106      252     +146     
Impacted Files Coverage Δ
js/class.js 63.88% <0.00%> (ø)
modules/default/calendar/calendarutils.js 56.20% <0.00%> (ø)
modules/default/calendar/calendarfetcher.js 80.32% <0.00%> (ø)
modules/default/calendar/node_helper.js 54.28% <0.00%> (ø)
js/node_helper.js 78.04% <0.00%> (ø)
js/server.js 67.56% <0.00%> (+1.35%) ⬆️
js/app.js 70.24% <0.00%> (+9.91%) ⬆️
js/fetch.js 83.33% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tests/electron/modules/compliments_spec.js Outdated Show resolved Hide resolved
@khassel khassel requested a review from rejas October 16, 2022 21:48
@rejas rejas merged commit ad4dbd7 into MagicMirrorOrg:develop Oct 17, 2022
@khassel khassel deleted the electron-tests branch October 17, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants