-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Collaboration.md #2954
add Collaboration.md #2954
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2954 +/- ##
===========================================
- Coverage 65.28% 65.21% -0.08%
===========================================
Files 14 14
Lines 726 733 +7
===========================================
+ Hits 474 478 +4
- Misses 252 255 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
2d44d1b
to
0a37da3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I'm not an official reviewer, it looks good to me too 🙂
Good morning @sdetweil are you fine with these ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, looks good
by the way, might it make sense to add @MichMich to the discurs channel too? |
As already discussed here the first shot of the collaboration rules.
We can discuss this in the comments until ready to merge.