Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace … with #2973

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Replace … with #2973

merged 2 commits into from
Dec 10, 2022

Conversation

KristjanESPERANTO
Copy link
Contributor

I think it is clearer if we don't use the HTML entity.

@codecov-commenter
Copy link

Codecov Report

Merging #2973 (af50f23) into develop (bd0b3c0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2973      +/-   ##
===========================================
+ Coverage    22.88%   22.93%   +0.05%     
===========================================
  Files           51       51              
  Lines        10895    10895              
===========================================
+ Hits          2493     2499       +6     
+ Misses        8402     8396       -6     
Impacted Files Coverage Δ
modules/default/calendar/calendar.js 33.29% <100.00%> (ø)
modules/default/updatenotification/node_helper.js 74.28% <0.00%> (+8.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas
Copy link
Collaborator

rejas commented Nov 27, 2022

Maybe we can remove the safe markers for nunjucks now? see #2427

@khassel
Copy link
Collaborator

khassel commented Dec 10, 2022

Maybe we can remove the safe markers for nunjucks now? see #2427

so should this be done with this PR oder in another one?

@rejas
Copy link
Collaborator

rejas commented Dec 10, 2022

I'd prefere a second PR if one of you could do it. Dont think it should go into the next release since it might need some feedback if it breaks something.

@khassel khassel merged commit 3124b0a into MagicMirrorOrg:develop Dec 10, 2022
@KristjanESPERANTO KristjanESPERANTO deleted the develop branch December 10, 2022 22:00
@khassel khassel mentioned this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants