Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single config backup file when config.template is used #3104

Merged
merged 2 commits into from
May 15, 2023
Merged

Use single config backup file when config.template is used #3104

merged 2 commits into from
May 15, 2023

Conversation

oscarb
Copy link
Contributor

@oscarb oscarb commented May 14, 2023

Copy config.js to a single config.js-old file whenever a config.template is present, instead of using Date() as a suffix. Creating files with a timestamp suffix means that whenever Magic Mirror is restarted or recreated a new file is written into the config directory.

Benefits:

  • Single backup file will avoid excessive writing of files
  • Saves space and usage on SD cards.
  • Makes the folder cleaner and easier to overview, compared to ending up with something like this as time goes on:
    image

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #3104 (c7e50e9) into develop (d832d79) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3104      +/-   ##
===========================================
+ Coverage    25.53%   25.57%   +0.04%     
===========================================
  Files           53       53              
  Lines        11420    11420              
===========================================
+ Hits          2916     2921       +5     
+ Misses        8504     8499       -5     
Impacted Files Coverage Δ
js/app.js 79.88% <0.00%> (ø)

... and 1 file with indirect coverage changes

@rejas
Copy link
Collaborator

rejas commented May 15, 2023

Thx for the PR, I am fine with it.
What dou you think @khassel as the OC (original coder)?

@khassel khassel merged commit e09d60d into MagicMirrorOrg:develop May 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants