Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on rrule.between returned bad dates #3256 #3257

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

sdetweil
Copy link
Collaborator

@sdetweil sdetweil commented Oct 31, 2023

Fixes: #3256

BUT.. the testcase is inconclusive.. as the code FAILS without the fix, BUT somehow RETURNS 0 entries..
in real life run the node helper fails, and all calendar processing stops.

@sdetweil
Copy link
Collaborator Author

this fails cause of the other calendar fix failure.

@sdetweil sdetweil changed the title fix rrule.between crash on bad dates #3256 fix crash on rrule.between returned bad dates #3256 Oct 31, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
tests/configs/modules/calendar/bad_rrule.js Outdated Show resolved Hide resolved
@sdetweil sdetweil requested a review from rejas November 1, 2023 12:52
@sdetweil
Copy link
Collaborator Author

sdetweil commented Nov 7, 2023

because they produced errors in prettier about no ruleset. same as the ics

@rejas rejas merged commit b300191 into MagicMirrorOrg:develop Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants