Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM² Icon #3407

Merged
merged 10 commits into from
Mar 28, 2024
Merged

MM² Icon #3407

merged 10 commits into from
Mar 28, 2024

Conversation

bugsounet
Copy link
Contributor

@bugsounet bugsounet commented Mar 28, 2024 •
edited
Loading

  • Create MM² icon
  • Allow to change default electron icon to this icon

rejas
rejas requested changes Mar 28, 2024
View reviewed changes
MM².png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea. but can you name the file jsut mm2.png without the high 2 ? dont want to risk the spelling to condfuse some filesystems :-)

@KristjanESPERANTO
Copy link
Contributor

Out of curiosity: When and where is the icon displayed?

@bugsounet
Copy link
Contributor Author

@rejas: wait, I will change "MM" color because it's so darkness... we see nothing lol

@bugsounet
Copy link
Contributor Author

@KristjanESPERANTO

something like this ?

image

and task bar (when minified or when multi-screen using)
image

@bugsounet
Copy link
Contributor Author

@veeck, it's ok (i think)

@rejas rejas merged commit d9926fa into MagicMirrorOrg:develop Mar 28, 2024
6 checks passed
@khassel
Copy link
Collaborator

khassel commented Mar 28, 2024

so this is the new favicon when running under electron (which is only visible if not running fullscreen), but for server only we have another favicon in index.html. So should we use the same icon for both?

@rejas
Copy link
Collaborator

rejas commented Mar 28, 2024

that index.html favicon is this base64 encoded small string?

@khassel
Copy link
Collaborator

khassel commented Mar 28, 2024

I think so, displayed is
grafik

@khassel
Copy link
Collaborator

khassel commented Mar 28, 2024

you can replace this line e.g. with

<link rel="icon" type="image/png" href="path/file.png">

to test other icons (the path must served by mm)

@bugsounet
Copy link
Contributor Author

will not works mm2.png have no entry on express

@khassel
Copy link
Collaborator

khassel commented Mar 28, 2024 •
edited
Loading

that was meant with "the path must served by mm", for testing it must be copied to e.g. config or modules or ...

@bugsounet
Copy link
Contributor Author

add an app.get to serve mm2.png in server.js ;)
I'm in lazy mode :D

@rejas
Copy link
Collaborator

rejas commented Mar 28, 2024

unifying them would make sense. and maybe also ask in the forum if we want to make a "design the mm2 logo" contest (no offence against your design, bugsounet, but we are developers, no designers :-)

@bugsounet
Copy link
Contributor Author

bugsounet commented Mar 28, 2024 •
edited
Loading

sure it's an first approach... I have planned to do that in next version of MM² (with ratio)

After why not ask in forum :)

@rejas rejas mentioned this pull request Apr 1, 2024
Merged
rejas added a commit that referenced this pull request Apr 1, 2024
@rejas @MichMich
@KristjanESPERANTO @dependabot @khassel @crazyscot @bugsounet @jkriegshauser @illimarkangur @sdetweil @vppencilsharpener @Paranoid93
Release 2.27.0 (#3410)
5ea8a34 
## [2.27.0] - 2024-04-01

Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser,
@khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and
@vppencilsharpener.

This release marks the first release without Michael Teeuw (@MichMich).
A very special thanks to him for creating MagicMirror and leading the
project for so many years.

For more info, please read the following post: [A New Chapter for
MagicMirror: The Community Takes the
Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead).

### Added

- Output of system information to the console for troubleshooting (#3328
and #3337), ignore errors under aarch64 (#3349)
- [chore] Add `eslint-plugin-package-json` to lint the `package.json`
files (#3368)
- [weather] `showHumidity` config is now a string describing where to
show this element. Supported values: "wind", "temp", "feelslike",
"below", "none". (#3330)
- electron-rebuild test suite for electron and 3rd party modules
compatibility (#3392)
- Create MM² icon and attach it to electron process (#3407)

### Updated

- Update updatenotification (update_helper.js): Recode with pm2 library
(#3332)
- Removing lodash dependency by replacing merge by spread operator
(#3339)
- Use node prefix for build-in modules (#3340)
- Rework logging colors (#3350)
- Update pm2 to v5.3.1 with no allow-ghsas (#3364)
- [chore] Update husky and let lint-staged fix ESLint issues
- [chore] Update dependencies including electron to v29 (#3357) and
node-ical
- Update translations for estonian (#3371)
- Update electron to v29 and update other dependencies
- [calendar] fullDay events over several days now show the left days
from the first day on and 'today' on the last day
- Update layout of current weather indoor values

### Fixed

- Correct apibase of weathergov weatherprovider to match documentation
(#2926)
- Worked around several issues in the RRULE library that were causing
deleted calender events to still show, some
initial and recurring events to not show, and some event times to be off
an hour. (#3291)
- Skip changelog requirement when running tests for dependency updates
(#3320)
- Display precipitation probability when it is 0% instead of blank/empty
(#3345)
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1
active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper
function (#3336)
- Ignore all custom css files (#3359)
- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361)
- Changed `log.debug` to `log.log` in `app.js` where logLevel is not set
because config is not loaded at this time (#3353)
- [calendar] deny fetch interval < 60000 and set 60000 in this case
(prevent fetch loop failed) (#3382)
- added message in case where config.js is missing the module.export
line PR #3383
- Fixed an issue where recurring events could extend past their
recurrence end date (#3393)
- Don't display any `npm WARN <....>` on install (#3399)
- Fixed move suncalc dependency to production from dev, as it is used by
clock module
- [compliments] Fix mirror not responding anymore when no compliments
are to be shown (#3385)

### Deleted

- Unneeded file headers (#3358)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
@wenBaiyun-11 wenBaiyun-11 mentioned this pull request Apr 9, 2024
Merged
@bugsounet bugsounet deleted the ico branch April 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bugsounet @KristjanESPERANTO @khassel @rejas