updatenotification: check Active (something displayed)

[bugsounet]

Added:

• check if module is active (avoid unwanted <div></div> and module spacing)

this need #3425, should I merge with it and make one PR only ?

[sdetweil]

what do you mean active? not hidden?

not active mean display:none;

modules are ALWAYS 'active' , just not displayed..
could be working in the background..
with display:none the content doesn't go away.

if a module is not loaded, then it is not there at all.

[bugsounet]

inactive -> nothing displayed ;)
active -> updatenotification display something

Why i add this:

• If you set a background in this module, you have a strange result

like this:

in top bar: it's the result of <div></div> and nothing displayed of updatenotification

[sdetweil]

what module?

[bugsounet]

I don't understand, what module ? sorry :/

[sdetweil]

you said if you add a background in this module, I want to see the module, and its source code
we shouldn't be overcorrecting for bad implementation

hide should kill its background as its a z-index, not a diifferent dom placement

[bugsounet]

euh ... this module is updatenotification ;)

[sdetweil]

how would updatenotification get a background, it's not coded for one in css or njk

[bugsounet]

after.... maybe i'm crazy ... but if you apply a padding to updatenotification with some effect
you have "color band"

css:

.module-content > *:not(.inactive):not(.hidden) {
    padding: 5px;
    border-radius: 10px;
    box-shadow: -5px -5px 8px #000;
    background: rgba(0, 0, 0, 15%);
    backdrop-filter: blur(5px);
    border: 1px solid rgba(255, 255, 255, 10%);
}

[bugsounet]

I think, that i'm not ONLY in the same case or ... I have to return to code learning school :) :) :)

and ... no "color bar"

[sdetweil]

what is the content normally, not hidden, just the empty div from the njk?

[bugsounet]

yes it's the <div></div> (empty) when nothing is displayed

[bugsounet]

the better way (for me) is add an display: none style when nothing is displayed

BUT:

• updateDom() is not async... so you can't await for add/del an "inactive" class
• updateDom() have no callback when done

So...

• maybe create an callback option with DOM_CONTENT_UPDATED notification

something like:

updateDom({ options : { callback: true } })

• or again call a function

updateDom({ options : { callback: myfonction() } })

in all case ... thanks njk :)

[sdetweil]

there is no getDom() with templated modules

it's getTemplateData()

see weather.js

[bugsounet]

already tested.
-> you can't play with the main njk div content
-> njk result is inside njk main div content -> <div> ... njk decoded ... </div>

Note that why I have added this

div.className = `${this.name}-njk`;`

in module.js

[sdetweil]

but why do you need that? module is over that and you can get the div below module-content, easy w jquery. and just as easy in css file.

as we havent had any reports of UN showing when hidden.. what's the problem u are trying to solve?

[bugsounet]

I was simply trying not to display an empty div which causes a color band when using css padding on this div
Only when the module displays the following result <div></div>
I report the module name: updatenotification

now if you can determine it with css: well done
adding jQuery to updatenotification a joke?

In all case, you have right sam, it's noted : no report = no change

I just added disabled: true in config and magical there is no color band.

Can I close #3425 too then (because one needs the other) ?
Because no updateDom() callback is needed and no njk classname div is require

[bugsounet]

more seriously, it's solved with this CSS pointer

.module-content > *:not(:empty) {
 <...>
}

[sdetweil]

just for clarity and accuracy, that is called the selector

of course it needs the module name class prefix so.it doesn't apply to all .modules

[bugsounet]

No no, there is no report about this, so i made no change
It's works since many year like that

[bugsounet]

@sdetweil It's ok for you ? because it's very clear for me